[PR #142] [MERGED] Enable ts-strict #638

New issue

Closed

opened 2026-10-31 22:15:29 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/142
Author: @huchenlei
Created: 10/30/2024
Status: ✅ Merged
Merged: 10/30/2024
Merged by: @huchenlei

Base: main ← Head: ts_strict

📝 Commits (8)

8b9908a Enable ts-strict
8daa8b0 Fix strict errors
b24c603 Fix some main.ts errors
c374d94 Fix rest of errors
b1d69c7 nit
2533227 Add typecheck to CI action
373b01d Add pre-commit strict check
04d49c1 Fix import

📊 Changes

7 files changed (+95 additions, -66 deletions)

View changed files

📝 .github/workflows/ci.yaml (+6 -1)
📝 package.json (+2 -4)
📝 src/__tests__/e2e/startup.test.ts (+2 -2)
📝 src/main.ts (+79 -55)
📝 src/models/DownloadManager.ts (+4 -3)
📝 src/pythonEnvironment.ts (+1 -1)
📝 tsconfig.json (+1 -0)

📄 Description

Resolves https://github.com/Comfy-Org/electron/issues/141

This PR:

Enables strict in tsconfig
Adds typecheck to CI action
Adds pre-commit typecheck hook

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/142 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `ts_strict` --- ### 📝 Commits (8) - [`8b9908a`](https://github.com/Comfy-Org/desktop/commit/8b9908aa50500965b95027e09874ddad31a088f7) Enable ts-strict - [`8daa8b0`](https://github.com/Comfy-Org/desktop/commit/8daa8b0b5b09bfe8b140510efa79717d5940bf48) Fix strict errors - [`b24c603`](https://github.com/Comfy-Org/desktop/commit/b24c603fc5ee78d3a15de7d2811437bbbd7cf472) Fix some main.ts errors - [`c374d94`](https://github.com/Comfy-Org/desktop/commit/c374d94816c329350d16ace7427351795587a6cf) Fix rest of errors - [`b1d69c7`](https://github.com/Comfy-Org/desktop/commit/b1d69c73d888239e2add0bc883111c68fa3f25a9) nit - [`2533227`](https://github.com/Comfy-Org/desktop/commit/25332277f57f68ab2492b8aa33b692d607767042) Add typecheck to CI action - [`373b01d`](https://github.com/Comfy-Org/desktop/commit/373b01d9b581af159a6cba1e37456fdd5c46d657) Add pre-commit strict check - [`04d49c1`](https://github.com/Comfy-Org/desktop/commit/04d49c13142e8b6b31ae441fcc5d67a90f569dc1) Fix import ### 📊 Changes **7 files changed** (+95 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yaml` (+6 -1) 📝 `package.json` (+2 -4) 📝 `src/__tests__/e2e/startup.test.ts` (+2 -2) 📝 `src/main.ts` (+79 -55) 📝 `src/models/DownloadManager.ts` (+4 -3) 📝 `src/pythonEnvironment.ts` (+1 -1) 📝 `tsconfig.json` (+1 -0) </details> ### 📄 Description Resolves https://github.com/Comfy-Org/electron/issues/141 This PR: - Enables strict in tsconfig - Adds typecheck to CI action - Adds pre-commit typecheck hook --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:29 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:31 +00:00

[PR #638] [MERGED] Sort imports with prettier #983

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#638

No description provided.

Rows
Columns