[PR #986] [MERGED] [API] Prefer enum over loose constants #1259

New issue

Closed

opened 2026-10-31 22:20:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/986
Author: @webfiltered
Created: 2/23/2025
Status: ✅ Merged
Merged: 2/23/2025
Merged by: @webfiltered

Base: main ← Head: api-enums

📝 Commits (2)

87906e9 [API] Prefer enum over loose constants
1095e0b [Cleanup] Remove unused constants

📊 Changes

5 files changed (+38 additions, -20 deletions)

View changed files

📝 src/constants.ts (+23 -5)
📝 src/main-process/comfyServer.ts (+2 -2)
📝 src/services/sentry.ts (+3 -3)
📝 src/virtualEnvironment.ts (+7 -7)
📝 tests/integration/testEnvironment.ts (+3 -3)

📄 Description

Deprecates old loose constants in favour of string enums.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/986 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/23/2025 **Status:** ✅ Merged **Merged:** 2/23/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `api-enums` --- ### 📝 Commits (2) - [`87906e9`](https://github.com/Comfy-Org/desktop/commit/87906e9f61ca6b10db104bfa19ecc7bfedfb93ad) [API] Prefer enum over loose constants - [`1095e0b`](https://github.com/Comfy-Org/desktop/commit/1095e0b10fb2d26e24385cf0c467b5c730e48530) [Cleanup] Remove unused constants ### 📊 Changes **5 files changed** (+38 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `src/constants.ts` (+23 -5) 📝 `src/main-process/comfyServer.ts` (+2 -2) 📝 `src/services/sentry.ts` (+3 -3) 📝 `src/virtualEnvironment.ts` (+7 -7) 📝 `tests/integration/testEnvironment.ts` (+3 -3) </details> ### 📄 Description Deprecates old loose constants in favour of string enums. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-986-API-Prefer-enum-over-loose-constants-1a36d73d36508183ad23d3b86d4364be) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:54 +00:00