[PR #642] [MERGED] Verify electron build after yarn:make #986

New issue

Closed

opened 2026-10-31 22:18:32 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/642
Author: @robinjhuang
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @robinjhuang

Base: main ← Head: rh-verify

📝 Commits (5)

a2ea550 Verify build for mac and windows.
47504dc Install uv as part of make process.
6e2994c Remove extra download uv command.
343fda4 Fix command.
8e10e43 add .exe suffix for windows

📊 Changes

6 files changed (+65 additions, -11 deletions)

View changed files

📝 .github/actions/build/todesktop/action.yml (+0 -2)
📝 README.md (+0 -6)
📝 builder-debug.config.ts (+1 -2)
📝 package.json (+2 -1)
📝 scripts/makeComfy.js (+1 -0)
➕ scripts/verifyBuild.js (+61 -0)

📄 Description

Add uv to electron builder local build config (builder-debug.config.ts)
Verify that uv, ComfyUI, and UI directories exist in resulting build
Make downloading uv part of the yarn make:assets command

Fixes: currently uv is not part of the yarn make build artifact. We had an extra step in the todesktop build to download it. This PR adds everything to yarn:make:assets do you only need to run a single command to get everything needed to start the application.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/642 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-verify` --- ### 📝 Commits (5) - [`a2ea550`](https://github.com/Comfy-Org/desktop/commit/a2ea5502e60c01f1266d3ef25d0294ce50763cb3) Verify build for mac and windows. - [`47504dc`](https://github.com/Comfy-Org/desktop/commit/47504dc1e14b902ba0a1b613bf69f13ef682839e) Install uv as part of make process. - [`6e2994c`](https://github.com/Comfy-Org/desktop/commit/6e2994cefe162338475a2a73d78f5d9448411f57) Remove extra download uv command. - [`343fda4`](https://github.com/Comfy-Org/desktop/commit/343fda4e8f5a9e14b5801bdd90e8da66924fd47f) Fix command. - [`8e10e43`](https://github.com/Comfy-Org/desktop/commit/8e10e43251fb64763b3aea3e4ec9fedb243d5660) add .exe suffix for windows ### 📊 Changes **6 files changed** (+65 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/todesktop/action.yml` (+0 -2) 📝 `README.md` (+0 -6) 📝 `builder-debug.config.ts` (+1 -2) 📝 `package.json` (+2 -1) 📝 `scripts/makeComfy.js` (+1 -0) ➕ `scripts/verifyBuild.js` (+61 -0) </details> ### 📄 Description - Add uv to electron builder local build config (`builder-debug.config.ts`) - Verify that uv, ComfyUI, and UI directories exist in resulting build - Make downloading uv part of the `yarn make:assets` command Fixes: currently uv is not part of the `yarn make` build artifact. We had an extra step in the todesktop build to download it. This PR adds everything to yarn:make:assets do you only need to run a single command to get everything needed to start the application. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:32 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:54 +00:00

[PR #986] [MERGED] [API] Prefer enum over loose constants #1259

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#986

No description provided.

Rows
Columns