[PR #146] [MERGED] Remove electron logviewer #642

New issue

Closed

opened 2026-10-31 22:15:32 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/146
Author: @huchenlei
Created: 10/30/2024
Status: ✅ Merged
Merged: 10/30/2024
Merged by: @huchenlei

Base: main ← Head: remove_logviewer

📝 Commits (3)

7338483 Remove electron logviewer
4220bbb Remove react-logviewer
1ddddfc nit

📊 Changes

8 files changed (+2 additions, -231 deletions)

View changed files

📝 package.json (+0 -1)
📝 src/constants.ts (+0 -2)
📝 src/main.ts (+0 -29)
📝 src/preload.ts (+0 -8)
📝 src/renderer/components/ComfyUIContainer.tsx (+1 -11)
➖ src/renderer/components/LogViewer.tsx (+0 -106)
📝 src/tray.ts (+0 -5)
📝 yarn.lock (+1 -69)

📄 Description

Partially revert https://github.com/Comfy-Org/electron/pull/105

Logviwer has been implemented in the frontend integrated in https://github.com/Comfy-Org/ComfyUI_frontend/pull/1295. Remove it from electron side.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/146 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `remove_logviewer` --- ### 📝 Commits (3) - [`7338483`](https://github.com/Comfy-Org/desktop/commit/7338483159af14c59558a73ed79fccb9b3796357) Remove electron logviewer - [`4220bbb`](https://github.com/Comfy-Org/desktop/commit/4220bbb1710800217837581fb3de4b9ec8b3e011) Remove react-logviewer - [`1ddddfc`](https://github.com/Comfy-Org/desktop/commit/1ddddfc972a47d78dee138d6fd1872bf1a9c8ade) nit ### 📊 Changes **8 files changed** (+2 additions, -231 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+0 -1) 📝 `src/constants.ts` (+0 -2) 📝 `src/main.ts` (+0 -29) 📝 `src/preload.ts` (+0 -8) 📝 `src/renderer/components/ComfyUIContainer.tsx` (+1 -11) ➖ `src/renderer/components/LogViewer.tsx` (+0 -106) 📝 `src/tray.ts` (+0 -5) 📝 `yarn.lock` (+1 -69) </details> ### 📄 Description Partially revert https://github.com/Comfy-Org/electron/pull/105 Logviwer has been implemented in the frontend integrated in https://github.com/Comfy-Org/ComfyUI_frontend/pull/1295. Remove it from electron side. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:32 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:32 +00:00

[PR #642] [MERGED] Verify electron build after yarn:make #986

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#642

No description provided.

Rows
Columns