[PR #985] [MERGED] [Cleanup] Remove redundant mock clearing #1261

New issue

Closed

opened 2026-10-31 22:20:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/985
Author: @webfiltered
Created: 2/23/2025
Status: ✅ Merged
Merged: 2/23/2025
Merged by: @webfiltered

Base: main ← Head: double-mock-clear

📝 Commits (2)

5d3e549 [Cleanup] Remove redundant mock clearing
3b0f9bd nit

📊 Changes

14 files changed (+7 additions, -57 deletions)

View changed files

📝 tests/unit/config/comfyConfigManager.test.ts (+1 -10)
📝 tests/unit/config/comfyServerConfig.test.ts (+1 -5)
📝 tests/unit/config/comfySettings.test.ts (+0 -7)
📝 tests/unit/handlers/AppHandlers.test.ts (+1 -5)
📝 tests/unit/handlers/appinfoHandlers.test.ts (+1 -5)
📝 tests/unit/handlers/pathHandler.test.ts (+0 -1)
📝 tests/unit/install/installWizard.test.ts (+0 -1)
📝 tests/unit/install/installationManager.test.ts (+0 -1)
📝 tests/unit/main-process/appState.test.ts (+0 -1)
📝 tests/unit/main-process/comfyDesktopApp.test.ts (+0 -3)
📝 tests/unit/main-process/comfyServer.test.ts (+1 -5)
📝 tests/unit/services/telemetry.test.ts (+0 -2)
📝 tests/unit/store/desktopConfig.test.ts (+1 -5)
📝 tests/unit/utils.test.ts (+1 -6)

📄 Description

#978 completely resets state between tests. This PR cleans up the redundant manual clearing (by various methods) in individual files.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/985 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/23/2025 **Status:** ✅ Merged **Merged:** 2/23/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `double-mock-clear` --- ### 📝 Commits (2) - [`5d3e549`](https://github.com/Comfy-Org/desktop/commit/5d3e5494c477f572f5152ba4231c3d46ee5d3bcb) [Cleanup] Remove redundant mock clearing - [`3b0f9bd`](https://github.com/Comfy-Org/desktop/commit/3b0f9bd8cd37ac5a0170cf7a889d7906d6db4664) nit ### 📊 Changes **14 files changed** (+7 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `tests/unit/config/comfyConfigManager.test.ts` (+1 -10) 📝 `tests/unit/config/comfyServerConfig.test.ts` (+1 -5) 📝 `tests/unit/config/comfySettings.test.ts` (+0 -7) 📝 `tests/unit/handlers/AppHandlers.test.ts` (+1 -5) 📝 `tests/unit/handlers/appinfoHandlers.test.ts` (+1 -5) 📝 `tests/unit/handlers/pathHandler.test.ts` (+0 -1) 📝 `tests/unit/install/installWizard.test.ts` (+0 -1) 📝 `tests/unit/install/installationManager.test.ts` (+0 -1) 📝 `tests/unit/main-process/appState.test.ts` (+0 -1) 📝 `tests/unit/main-process/comfyDesktopApp.test.ts` (+0 -3) 📝 `tests/unit/main-process/comfyServer.test.ts` (+1 -5) 📝 `tests/unit/services/telemetry.test.ts` (+0 -2) 📝 `tests/unit/store/desktopConfig.test.ts` (+1 -5) 📝 `tests/unit/utils.test.ts` (+1 -6) </details> ### 📄 Description #978 completely resets state between tests. This PR cleans up the redundant manual clearing (by various methods) in individual files. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-985-Cleanup-Remove-redundant-mock-clearing-1a36d73d365081bfbca2ca7ea95ac6a5) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:54 +00:00