[PR #632] [MERGED] Add updated metrics consent prompt #978

New issue

Closed

opened 2026-10-31 22:18:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/632
Author: @christian-byrne
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @huchenlei

Base: main ← Head: metrics-consent

📝 Commits (10+)

0516925 Add metrics consent handling
e69c02c Remove unnecessary frontend setting
7a600a7 Refactor
849a48f Add unit test
afe4f4f Refactor
747a968 Refactor
bdea512 Refactor
db55d09 Inline handler
ab92ea9 Fix type in tests
cce8c1e Merge branch 'main' into metrics-consent

📊 Changes

10 files changed (+237 additions, -8 deletions)

View changed files

📝 global.d.ts (+1 -0)
📝 src/constants.ts (+1 -0)
📝 src/install/installationManager.ts (+1 -0)
📝 src/main.ts (+7 -6)
📝 src/preload.ts (+3 -0)
📝 src/services/telemetry.ts (+31 -0)
📝 src/store/desktopSettings.ts (+2 -0)
📝 src/utils.ts (+23 -0)
📝 tests/unit/telemetry.test.ts (+167 -2)
📝 vite.base.config.ts (+1 -0)

📄 Description

This PR adds a function which checks the status of the user's allowMetrics/SendStatistics setting. If the user previously opted-in, they will be prompted to confirm their choice given the new metrics policy, with the option to disable.

Any new user installing will have the flag updatedMetricsConsent set during install, bypassing this process.

The UI component is in this frontend PR: https://github.com/Comfy-Org/ComfyUI_frontend/pull/2268

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/632 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `metrics-consent` --- ### 📝 Commits (10+) - [`0516925`](https://github.com/Comfy-Org/desktop/commit/0516925d1c4a46ed380d222a876522f24d16f169) Add metrics consent handling - [`e69c02c`](https://github.com/Comfy-Org/desktop/commit/e69c02c112ab036204d81abd2a10bea50902a7d7) Remove unnecessary frontend setting - [`7a600a7`](https://github.com/Comfy-Org/desktop/commit/7a600a74041c00879b6c647c9f53393180daecac) Refactor - [`849a48f`](https://github.com/Comfy-Org/desktop/commit/849a48f42e1390db2beea04e93e1a9502af1aa32) Add unit test - [`afe4f4f`](https://github.com/Comfy-Org/desktop/commit/afe4f4f67b68cf9604d604d70473fe57f16d6af4) Refactor - [`747a968`](https://github.com/Comfy-Org/desktop/commit/747a968ee1e8a46a85b56cd320c340ed61c8f508) Refactor - [`bdea512`](https://github.com/Comfy-Org/desktop/commit/bdea512a33f6a857fbbaa8e41ee59b72c08575a8) Refactor - [`db55d09`](https://github.com/Comfy-Org/desktop/commit/db55d09307e09a77717d2cb4fad32b225ed72af7) Inline handler - [`ab92ea9`](https://github.com/Comfy-Org/desktop/commit/ab92ea9997a89ae81b28bcb8f28b17067da326bd) Fix type in tests - [`cce8c1e`](https://github.com/Comfy-Org/desktop/commit/cce8c1e7df1451a9f984c55bd173f6016ea28a0f) Merge branch 'main' into metrics-consent ### 📊 Changes **10 files changed** (+237 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `global.d.ts` (+1 -0) 📝 `src/constants.ts` (+1 -0) 📝 `src/install/installationManager.ts` (+1 -0) 📝 `src/main.ts` (+7 -6) 📝 `src/preload.ts` (+3 -0) 📝 `src/services/telemetry.ts` (+31 -0) 📝 `src/store/desktopSettings.ts` (+2 -0) 📝 `src/utils.ts` (+23 -0) 📝 `tests/unit/telemetry.test.ts` (+167 -2) 📝 `vite.base.config.ts` (+1 -0) </details> ### 📄 Description This PR adds a function which checks the status of the user's allowMetrics/SendStatistics setting. If the user previously opted-in, they will be prompted to confirm their choice given the new metrics policy, with the option to disable. Any new user installing will have the flag `updatedMetricsConsent` set during install, bypassing this process. The UI component is in this frontend PR: https://github.com/Comfy-Org/ComfyUI_frontend/pull/2268 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-632-Add-updated-metrics-consent-prompt-17d6d73d365081f8bad7e41e379c9a66) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:28 +00:00