[PR #133] [MERGED] Todesktop - Windows Mac Build/Sign Complete #632

New issue

Closed

opened 2026-10-31 22:15:26 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/133
Author: @KenCorma
Created: 10/28/2024
Status: ✅ Merged
Merged: 10/28/2024
Merged by: @robinjhuang

Base: main ← Head: dev-todesktop-ci

📝 Commits (10+)

3446e6f switch some to spawnSync
5caa211 changed sign command
0223866 remove .git this way
581c784 had the remove git on the wrong platform
71340ef use remove symlink function
efe762b omg forgot require.
ea703ec this was an object
99df28b check symlinks on main and add output for rm/cp
2dc9a0d remove other python folder and use symlink test
8c85996 remove the tar.gz after usage

📊 Changes

10 files changed (+275 additions, -132 deletions)

View changed files

📝 .github/actions/build/windows/todesktop/action.yml (+0 -2)
📝 package.json (+1 -1)
📝 scripts/signPython.sh (+24 -14)
📝 scripts/todesktop/afterPack.js (+84 -1)
📝 scripts/todesktop/beforeInstall.js (+3 -5)
📝 scripts/todesktop/postInstall.js (+23 -9)
📝 src/main.ts (+1 -1)
📝 src/pythonEnvironment.ts (+24 -0)
📝 todesktop.json (+1 -1)
📝 yarn.lock (+114 -98)

📄 Description

Running the publish CI action will now send the project to toDesktop to be built and potentially publish.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/133 **Author:** [@KenCorma](https://github.com/KenCorma) **Created:** 10/28/2024 **Status:** ✅ Merged **Merged:** 10/28/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `dev-todesktop-ci` --- ### 📝 Commits (10+) - [`3446e6f`](https://github.com/Comfy-Org/desktop/commit/3446e6f9d0fa25cd17b5dfb0946f935d57c75b6b) switch some to spawnSync - [`5caa211`](https://github.com/Comfy-Org/desktop/commit/5caa211eccac90fd86acca5ae4f2ceb7a77ab03d) changed sign command - [`0223866`](https://github.com/Comfy-Org/desktop/commit/0223866b1f6686dce83790138358386f57c88d85) remove .git this way - [`581c784`](https://github.com/Comfy-Org/desktop/commit/581c784560a0b70ef45bf92aebf61dcaf7f60cc4) had the remove git on the wrong platform - [`71340ef`](https://github.com/Comfy-Org/desktop/commit/71340ef5d59f2a96a1105f46102a189435216076) use remove symlink function - [`efe762b`](https://github.com/Comfy-Org/desktop/commit/efe762b3e5d9dd8fdd70c9c854eb2f92cb9664ee) omg forgot require. - [`ea703ec`](https://github.com/Comfy-Org/desktop/commit/ea703ecfd82788ff955f01da081a07c2fcf136bf) this was an object - [`99df28b`](https://github.com/Comfy-Org/desktop/commit/99df28b923c899273a860b468b08f180dfffcd9e) check symlinks on main and add output for rm/cp - [`2dc9a0d`](https://github.com/Comfy-Org/desktop/commit/2dc9a0d066c6941ebf97e3ea002317470e9a763f) remove other python folder and use symlink test - [`8c85996`](https://github.com/Comfy-Org/desktop/commit/8c85996a66ce188b5dd699680ed0781ca0c4ec3c) remove the tar.gz after usage ### 📊 Changes **10 files changed** (+275 additions, -132 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/windows/todesktop/action.yml` (+0 -2) 📝 `package.json` (+1 -1) 📝 `scripts/signPython.sh` (+24 -14) 📝 `scripts/todesktop/afterPack.js` (+84 -1) 📝 `scripts/todesktop/beforeInstall.js` (+3 -5) 📝 `scripts/todesktop/postInstall.js` (+23 -9) 📝 `src/main.ts` (+1 -1) 📝 `src/pythonEnvironment.ts` (+24 -0) 📝 `todesktop.json` (+1 -1) 📝 `yarn.lock` (+114 -98) </details> ### 📄 Description Running the publish CI action will now send the project to toDesktop to be built and potentially publish. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:26 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:28 +00:00

[PR #632] [MERGED] Add updated metrics consent prompt #978

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#632

No description provided.

Rows
Columns