[PR #993] [MERGED] [e2e] Improve teardown - full desktop screenshot #1268

New issue

Closed

opened 2026-10-31 22:20:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/993
Author: @webfiltered
Created: 2/25/2025
Status: ✅ Merged
Merged: 2/25/2025
Merged by: @webfiltered

Base: main ← Head: e2e-cleanup

📝 Commits (3)

86a70dd [e2e] Always dispose temp dir
c8e67a6 [e2e] Screenshot entire desktop on close failure
0f074f5 nit

📊 Changes

5 files changed (+67 additions, -10 deletions)

View changed files

📝 tests/integration/post-install.teardown.ts (+2 -2)
📝 tests/integration/testApp.ts (+27 -7)
📝 tests/integration/testEnvironment.ts (+1 -0)
📝 tests/integration/testExtensions.ts (+1 -1)
📝 tests/shared/utils.ts (+36 -0)

📄 Description

Adds a full desktop screen shot on app install failure
Win32 only - logs an error on other platforms
Adds missing temp dir dispose (ensures removal in tear-down)

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/993 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 2/25/2025 **Status:** ✅ Merged **Merged:** 2/25/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `e2e-cleanup` --- ### 📝 Commits (3) - [`86a70dd`](https://github.com/Comfy-Org/desktop/commit/86a70dd0665b3cc3bf6ac11d4563c0430b4f29a2) [e2e] Always dispose temp dir - [`c8e67a6`](https://github.com/Comfy-Org/desktop/commit/c8e67a67c792692ef1841fb618f80c97d28b31c8) [e2e] Screenshot entire desktop on close failure - [`0f074f5`](https://github.com/Comfy-Org/desktop/commit/0f074f5034155515b1f7802e08c7ec7964ed3e3b) nit ### 📊 Changes **5 files changed** (+67 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `tests/integration/post-install.teardown.ts` (+2 -2) 📝 `tests/integration/testApp.ts` (+27 -7) 📝 `tests/integration/testEnvironment.ts` (+1 -0) 📝 `tests/integration/testExtensions.ts` (+1 -1) 📝 `tests/shared/utils.ts` (+36 -0) </details> ### 📄 Description - Adds a full desktop screen shot on app install failure - Win32 only - logs an error on other platforms - Adds missing temp dir dispose (ensures removal in tear-down) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-993-e2e-Improve-teardown-full-desktop-screenshot-1a56d73d36508167b6d7d981ef364c65) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:57 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1268

No description provided.

Rows
Columns