[PR #650] [MERGED] Fix regression: uv termianl cannot be restarted #993

New issue

Closed

opened 2026-10-31 22:18:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/650
Author: @webfiltered
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/16/2025
Merged by: @huchenlei

Base: main ← Head: virtenv-patch

📝 Commits (3)

05a3afc Fix regression: uv termianl cannot be restarted
c45360f nit
85433d6 nit - unused public member

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 src/virtualEnvironment.ts (+6 -2)

📄 Description

Cleanup virtualEnvironment.uvPty on process kill

Issue has no impact on prod, but is a regression.

This is a pre-requisite for validation, which can start and terminate a host shell process multiple times.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/650 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/16/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `virtenv-patch` --- ### 📝 Commits (3) - [`05a3afc`](https://github.com/Comfy-Org/desktop/commit/05a3afc3c867d2dafe24c2a33a56bbcbf163d7d4) Fix regression: uv termianl cannot be restarted - [`c45360f`](https://github.com/Comfy-Org/desktop/commit/c45360fcd52270d6cca3f5489dcb59a50eda3487) nit - [`85433d6`](https://github.com/Comfy-Org/desktop/commit/85433d6edace30034d4eb97d03a6ba56e6f0c906) nit - unused public member ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/virtualEnvironment.ts` (+6 -2) </details> ### 📄 Description Cleanup virtualEnvironment.uvPty on process kill Issue has no impact on prod, but is a regression. This is a pre-requisite for validation, which can start and terminate a host shell process multiple times. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-650-Fix-regression-uv-termianl-cannot-be-restarted-17d6d73d3650812dad00ec88dea90f48) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:35 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:57 +00:00

[PR #993] [MERGED] [e2e] Improve teardown - full desktop screenshot #1268

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#993

No description provided.

Rows
Columns