[PR #995] [CLOSED] Reinstall dependencies when detected by troubleshooting page #1271

New issue

Closed

opened 2026-10-31 22:20:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:20:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/995
Author: @robinjhuang
Created: 2/26/2025
Status: ❌ Closed

Base: main ← Head: rh-manager2

📝 Commits (2)

9551211 Revert "Add manager package checks (#841)"
24e2139 Reinstall comfyui dependencies.

📊 Changes

5 files changed (+17 additions, -56 deletions)

View changed files

📝 src/infrastructure/interfaces.ts (+1 -2)
📝 src/install/installationManager.ts (+8 -18)
📝 src/main-process/comfyInstallation.ts (+2 -13)
📝 src/preload.ts (+0 -1)
📝 src/virtualEnvironment.ts (+6 -22)

📄 Description

Reverted previous PR https://github.com/Comfy-Org/desktop/pull/841/files
When installation validation detects missing pythonPackages, try reinstalling once.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/995 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 2/26/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `rh-manager2` --- ### 📝 Commits (2) - [`9551211`](https://github.com/Comfy-Org/desktop/commit/9551211f39003e6f4d30218cab6eb607935206ad) Revert "Add manager package checks (#841)" - [`24e2139`](https://github.com/Comfy-Org/desktop/commit/24e2139851a368565cc65c5d8675b95aead28856) Reinstall comfyui dependencies. ### 📊 Changes **5 files changed** (+17 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `src/infrastructure/interfaces.ts` (+1 -2) 📝 `src/install/installationManager.ts` (+8 -18) 📝 `src/main-process/comfyInstallation.ts` (+2 -13) 📝 `src/preload.ts` (+0 -1) 📝 `src/virtualEnvironment.ts` (+6 -22) </details> ### 📄 Description - Reverted previous PR https://github.com/Comfy-Org/desktop/pull/841/files - When installation validation detects missing `pythonPackages`, try reinstalling once. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-995-Reinstall-dependencies-when-detected-by-troubleshooting-page-1a66d73d365081e1a88acd72041436ca) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:20:59 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:25 +00:00

[PR #1271] [MERGED] Revert "Update ComfyUI Manager to latest version (#1261)" #1447

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1271

No description provided.

Rows
Columns