[PR #652] [MERGED] Fix torch install failure is ignored #995

New issue

Closed

opened 2026-10-31 22:18:38 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:38 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/652
Author: @webfiltered
Created: 1/16/2025
Status: ✅ Merged
Merged: 1/17/2025
Merged by: @webfiltered

Base: main ← Head: fix-torch-install

📝 Commits (1)

1a7c09b Fix torch install failure is ignored

📊 Changes

1 file changed (+15 additions, -15 deletions)

View changed files

📝 src/virtualEnvironment.ts (+15 -15)

📄 Description

Installation will now throw on error, cancelling subsequent venv install tasks.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/652 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 1/16/2025 **Status:** ✅ Merged **Merged:** 1/17/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `fix-torch-install` --- ### 📝 Commits (1) - [`1a7c09b`](https://github.com/Comfy-Org/desktop/commit/1a7c09b0505d0425727f5177fac7e9a6472d6507) Fix torch install failure is ignored ### 📊 Changes **1 file changed** (+15 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/virtualEnvironment.ts` (+15 -15) </details> ### 📄 Description Installation will now throw on error, cancelling subsequent venv install tasks. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-652-Fix-torch-install-failure-is-ignored-17d6d73d365081589bc7d48fa77513c9) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:38 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:59 +00:00

[PR #995] [CLOSED] Reinstall dependencies when detected by troubleshooting page #1271

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#995

No description provided.

Rows
Columns