[PR #1020] [MERGED] [Workaround] Fix crash on start: missing frontend package #1291

New issue

Closed

opened 2026-10-31 22:21:10 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:21:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1020
Author: @webfiltered
Created: 3/5/2025
Status: ✅ Merged
Merged: 3/5/2025
Merged by: @webfiltered

Base: main ← Head: fix-frontend-package-missing

📝 Commits (5)

04d852f Partially revert "Update ComfyUI to v0.3.20 (#1017)"
28a394a Add dev dependency: diff
52256b9 Patch the frontend download out of ComfyUI core
999e0ae Add temporary core patch GH actions
23fd3d5 Update patch - restore original path

📊 Changes

11 files changed (+292 additions, -14 deletions)

View changed files

📝 .github/actions/build/macos/comfy/action.yml (+1 -0)
📝 .github/actions/build/todesktop/action.yml (+1 -0)
📝 .github/actions/build/windows/app/action.yml (+1 -0)
📝 assets/requirements/windows_cpu.compiled (+0 -6)
📝 assets/requirements/windows_nvidia.compiled (+0 -6)
📝 package.json (+3 -0)
➕ scripts/core-remove-frontend.patch (+29 -0)
➕ scripts/patchComfyUI.js (+32 -0)
➕ src/frontend_management.py (+207 -0)
📝 src/virtualEnvironment.ts (+2 -2)
📝 yarn.lock (+16 -0)

📄 Description

Adds diff package
Applies patch to remove changes to frontend_management.py that throw if frontend does not exist
Continues to use pre-packaged frontend as normal

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1020 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 3/5/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `fix-frontend-package-missing` --- ### 📝 Commits (5) - [`04d852f`](https://github.com/Comfy-Org/desktop/commit/04d852fb1898500d938d455b139e3793aed905cb) Partially revert "Update ComfyUI to v0.3.20 (#1017)" - [`28a394a`](https://github.com/Comfy-Org/desktop/commit/28a394af562402546ef4e0f967fd2adf1be179d5) Add dev dependency: diff - [`52256b9`](https://github.com/Comfy-Org/desktop/commit/52256b92bf602e8a06ab89bee2a9170eebca2949) Patch the frontend download out of ComfyUI core - [`999e0ae`](https://github.com/Comfy-Org/desktop/commit/999e0aef714cc75f0e6f9bdd466a7f5d41da98c3) Add temporary core patch GH actions - [`23fd3d5`](https://github.com/Comfy-Org/desktop/commit/23fd3d54c67bd3f294f3c9233bd310d3ab5d38ca) Update patch - restore original path ### 📊 Changes **11 files changed** (+292 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/macos/comfy/action.yml` (+1 -0) 📝 `.github/actions/build/todesktop/action.yml` (+1 -0) 📝 `.github/actions/build/windows/app/action.yml` (+1 -0) 📝 `assets/requirements/windows_cpu.compiled` (+0 -6) 📝 `assets/requirements/windows_nvidia.compiled` (+0 -6) 📝 `package.json` (+3 -0) ➕ `scripts/core-remove-frontend.patch` (+29 -0) ➕ `scripts/patchComfyUI.js` (+32 -0) ➕ `src/frontend_management.py` (+207 -0) 📝 `src/virtualEnvironment.ts` (+2 -2) 📝 `yarn.lock` (+16 -0) </details> ### 📄 Description - Adds diff package - Applies patch to remove changes to frontend_management.py that throw if frontend does not exist - Continues to use pre-packaged frontend as normal ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-1020-Workaround-Add-temporary-core-patch-for-frontend-pip-1ad6d73d36508162b158f75e6d42b5ab) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:21:10 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:22:33 +00:00

[PR #1291] [MERGED] Add missing corepack step to release workflow #1466

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1291

No description provided.

Rows
Columns