[PR #689] [MERGED] Track quitting and virtual env skip events. #1020

New issue

Closed

opened 2026-10-31 22:18:51 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:51 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/689
Author: @robinjhuang
Created: 1/21/2025
Status: ✅ Merged
Merged: 1/23/2025
Merged by: @robinjhuang

Base: main ← Head: rh-telemetry-followup

📝 Commits (2)

c31edf5 Track quitting and virtual env skip events.
2ebf8aa Track quit in a single listener.

📊 Changes

2 files changed (+21 additions, -5 deletions)

View changed files

📝 src/main.ts (+7 -0)
📝 src/virtualEnvironment.ts (+14 -5)

📄 Description

Utilize a single install_flow:virtual_environment_create_end event with properties indicating what the reason was.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/689 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 1/21/2025 **Status:** ✅ Merged **Merged:** 1/23/2025 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-telemetry-followup` --- ### 📝 Commits (2) - [`c31edf5`](https://github.com/Comfy-Org/desktop/commit/c31edf54e0d79f18b1f4db916dd90bac200d2995) Track quitting and virtual env skip events. - [`2ebf8aa`](https://github.com/Comfy-Org/desktop/commit/2ebf8aa7276c6ce4964c301316bbb29006438048) Track quit in a single listener. ### 📊 Changes **2 files changed** (+21 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/main.ts` (+7 -0) 📝 `src/virtualEnvironment.ts` (+14 -5) </details> ### 📄 Description Utilize a single `install_flow:virtual_environment_create_end` event with properties indicating what the reason was. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-689-Track-quitting-and-virtual-env-skip-events-1826d73d365081078e84f18bcd251e1d) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:51 +00:00