[PR #1024] [MERGED] [Workaround] Fix maintenance screen pip-installs frontend #1293

Closed
opened 2026-10-31 22:21:10 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/1024
Author: @webfiltered
Created: 3/5/2025
Status: ✅ Merged
Merged: 3/5/2025
Merged by: @webfiltered

Base: main ← Head: patch-requirements-txt


📝 Commits (4)

📊 Changes

4 files changed (+17 additions, -214 deletions)

View changed files

📝 scripts/core-remove-frontend.patch (+3 -3)
➕ scripts/core-requirements.patch (+9 -0)
📝 scripts/patchComfyUI.js (+5 -4)
➖ src/frontend_management.py (+0 -207)

📄 Description

  • Follow-up on #1020
  • Patches frontend package out of requirements.txt
  • Patch was applied in local testing, but missed on upload; caught by e2e

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/1024 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 3/5/2025 **Merged by:** [@webfiltered](https://github.com/webfiltered) **Base:** `main` ← **Head:** `patch-requirements-txt` --- ### 📝 Commits (4) - [`0aae786`](https://github.com/Comfy-Org/desktop/commit/0aae7861412b939344f2b76cdae2796bcb3fc273) nit - Remove unintentional addition - [`35a671c`](https://github.com/Comfy-Org/desktop/commit/35a671cab7315ee6d404cb91f3edf87eeddd0e43) Add missed patch for frontend pip package - [`ad1f2e2`](https://github.com/Comfy-Org/desktop/commit/ad1f2e2e01286543a40445ef99b92fd9c298d38a) nit - [`413903e`](https://github.com/Comfy-Org/desktop/commit/413903e7d0e54882bfe418d46814faf764209b0d) nit - Rename ### 📊 Changes **4 files changed** (+17 additions, -214 deletions) <details> <summary>View changed files</summary> 📝 `scripts/core-remove-frontend.patch` (+3 -3) ➕ `scripts/core-requirements.patch` (+9 -0) 📝 `scripts/patchComfyUI.js` (+5 -4) ➖ `src/frontend_management.py` (+0 -207) </details> ### 📄 Description - Follow-up on #1020 - Patches frontend package out of requirements.txt - Patch was applied in local testing, but missed on upload; caught by e2e --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 22:21:10 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#1293
No description provided.