[PR #694] [MERGED] [Test] Add unit tests for 100% coverage of pathHandlers #1024

New issue

Closed

opened 2026-10-31 22:18:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/694
Author: @christian-byrne
Created: 1/22/2025
Status: ✅ Merged
Merged: 1/22/2025
Merged by: @huchenlei

Base: main ← Head: unit-test/pathHandlers-p2

📝 Commits (2)

aca098c add tests on pathhandler methods
f698d0c refactor

📊 Changes

1 file changed (+197 additions, -34 deletions)

View changed files

📝 tests/unit/handlers/pathHandler.test.ts (+197 -34)

📄 Description

This PR extends unit tests on pathHandlers, bringing it to 100% coverage:

Additionally, the tests are refactored to be easier to extend in the future. Currently, only the described behavior of each handler is being asserted.

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/694 **Author:** [@christian-byrne](https://github.com/christian-byrne) **Created:** 1/22/2025 **Status:** ✅ Merged **Merged:** 1/22/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `unit-test/pathHandlers-p2` --- ### 📝 Commits (2) - [`aca098c`](https://github.com/Comfy-Org/desktop/commit/aca098ccfdf95187fbc96dd2dbad7ea96eca83c2) add tests on pathhandler methods - [`f698d0c`](https://github.com/Comfy-Org/desktop/commit/f698d0ca1ff216381227ee9138304c7b73095162) refactor ### 📊 Changes **1 file changed** (+197 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `tests/unit/handlers/pathHandler.test.ts` (+197 -34) </details> ### 📄 Description This PR extends unit tests on `pathHandlers`, bringing it to 100% coverage: ![Selection_791](https://github.com/user-attachments/assets/bd691b6f-07ab-40e1-9ae2-9ed5cf0dd012) Additionally, the tests are refactored to be easier to extend in the future. Currently, only the described behavior of each handler is being asserted. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-694-Test-Add-unit-tests-for-100-coverage-of-pathHandlers-1836d73d36508109b899c10b1c92693a) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:54 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:21:10 +00:00

[PR #1024] [MERGED] [Workaround] Fix maintenance screen pip-installs frontend #1293

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#1024

No description provided.

Rows
Columns