[PR #216] [CLOSED] Draft: Refactor installation state. #694

New issue

Closed

opened 2026-10-31 22:16:04 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:16:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/216
Author: @robinjhuang
Created: 11/10/2024
Status: ❌ Closed

Base: main ← Head: rh-install

📝 Commits (2)

c7ee7c2 Refactor install.
ce150c6 Valdiate.

📊 Changes

4 files changed (+136 additions, -42 deletions)

View changed files

📝 src/config/comfyConfigManager.ts (+3 -0)
📝 src/constants.ts (+4 -0)
➕ src/install/install.ts (+124 -0)
📝 src/main.ts (+5 -42)

📄 Description

Currently, the main process will send events and state to the renderer for the initial onboarding installation.

This is brittle because the renderer state can become out of sync if it misses messages.

This refactor stores the current state of the installation, and registers an IPC event so the renderer can always request the up to date state.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/216 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 11/10/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `rh-install` --- ### 📝 Commits (2) - [`c7ee7c2`](https://github.com/Comfy-Org/desktop/commit/c7ee7c2299896b4e23f5d88f6cff523d5851ad60) Refactor install. - [`ce150c6`](https://github.com/Comfy-Org/desktop/commit/ce150c66af8027a288e87e7b6b97f06c557b12f3) Valdiate. ### 📊 Changes **4 files changed** (+136 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `src/config/comfyConfigManager.ts` (+3 -0) 📝 `src/constants.ts` (+4 -0) ➕ `src/install/install.ts` (+124 -0) 📝 `src/main.ts` (+5 -42) </details> ### 📄 Description Currently, the main process will send events and state to the renderer for the initial onboarding installation. This is brittle because the renderer state can become out of sync if it misses messages. This refactor stores the current state of the installation, and registers an IPC event so the renderer can always request the up to date state. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:16:04 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:54 +00:00

[PR #694] [MERGED] [Test] Add unit tests for 100% coverage of pathHandlers #1024

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#694

No description provided.

Rows
Columns