Comfy-Org/desktop

Fork 0

mirror of https://github.com/Comfy-Org/desktop.git synced 2026-11-04 23:47:43 +00:00

[GH-ISSUE #653] [DevTask] Check contents of finished ToDesktop build #193

New issue

Closed

opened 2026-10-31 22:09:54 +00:00 by bsakaguchi · 2 comments

bsakaguchi commented

2026-10-31 22:09:54 +00:00

Owner

Originally created by @robinjhuang on GitHub (Jan 16, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/653

Currently, we check the contents of local yarn make builds. ToDesktop kicks off a slightly different process (using its own electron-builder config, which is mapped from the todesktop.json file.

We can add a check at the end of Publish All Github action to download the build and check the contents.

┆Issue is synchronized with this Notion page by Unito

Originally created by @robinjhuang on GitHub (Jan 16, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/653 Currently, we check the contents of local yarn make builds. ToDesktop kicks off a slightly different process (using its own electron-builder config, which is mapped from the `todesktop.json` file. We can add a check at the end of Publish All Github action to download the build and check the contents. ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-653-DevTask-Check-contents-of-finished-ToDesktop-build-17e6d73d365081369639d6e538bfd956) by [Unito](https://www.unito.io)

bsakaguchi closed this issue

2026-10-31 22:09:54 +00:00

bsakaguchi commented

2026-10-31 22:09:55 +00:00

Author

Owner

@robinjhuang commented on GitHub (Jan 17, 2025):

This is useful for checking some basics:

eg uv, COmfyUI, manager, and UI images are present in the build.

https://github.com/Comfy-Org/desktop/pull/642

@robinjhuang commented on GitHub (Jan 17, 2025): This is useful for checking some basics: eg uv, COmfyUI, manager, and UI images are present in the build. https://github.com/Comfy-Org/desktop/pull/642

bsakaguchi commented

2026-10-31 22:09:55 +00:00

Author

Owner

@dosubot[bot] commented on GitHub (Apr 18, 2025):

Hi, @robinjhuang. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

Proposal to add a verification step to the "Publish All" GitHub action.
Aimed at ensuring integrity of ToDesktop builds, which differ from local yarn make builds.
Suggests checking for essential components like COmfyUI, manager, and UI images.
References related pull request #642 for additional context.
Currently unresolved.

Next Steps:

Please confirm if this issue is still relevant to the latest version of the desktop repository by commenting here.
If there is no further activity, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot[bot] commented on GitHub (Apr 18, 2025): Hi, @robinjhuang. I'm [Dosu](https://dosu.dev), and I'm helping the desktop team manage their backlog. I'm marking this issue as stale. **Issue Summary:** - Proposal to add a verification step to the "Publish All" GitHub action. - Aimed at ensuring integrity of ToDesktop builds, which differ from local yarn make builds. - Suggests checking for essential components like COmfyUI, manager, and UI images. - References related pull request #642 for additional context. - Currently unresolved. **Next Steps:** - Please confirm if this issue is still relevant to the latest version of the desktop repository by commenting here. - If there is no further activity, the issue will be automatically closed in 7 days. Thank you for your understanding and contribution!

bsakaguchi referenced this issue

2026-10-31 22:15:53 +00:00

[PR #193] [MERGED] Access log folder in browser process #675

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#193

No description provided.

Rows
Columns