[GH-ISSUE #765] [DevTask] Refactor duplicate methods out of VirtualEnvironment #222

Closed
opened 2026-10-31 22:10:15 +00:00 by bsakaguchi · 1 comment
Owner

Originally created by @webfiltered on GitHub (Jan 29, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/765

During merge of maintenance PR, merge conflict resolution was achieved without re-testing by temporarily adding duplicate methods. These must be removed, with either the tasks or venv install refactored to all use the same API.

┆Issue is synchronized with this Notion page by Unito

Originally created by @webfiltered on GitHub (Jan 29, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/765 During merge of maintenance PR, merge conflict resolution was achieved without re-testing by temporarily adding duplicate methods. These must be removed, with either the tasks or venv install refactored to all use the same API. ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-765-DevTask-Refactor-duplicate-methods-out-of-VirtualEnvironment-18a6d73d365081cfbb2cd07005484995) by [Unito](https://www.unito.io)
Author
Owner

@dosubot[bot] commented on GitHub (Apr 30, 2025):

Hi, @webfiltered. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • The issue involves removing duplicate methods from the VirtualEnvironment.
  • These duplicates were introduced during a merge conflict resolution.
  • The aim is to refactor the code for a consistent API across tasks or virtual environment installations.
  • There have been no comments or activity since the issue was opened.

Next Steps:

  • Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here.
  • If there is no further activity, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

<!-- gh-comment-id:2842481819 --> @dosubot[bot] commented on GitHub (Apr 30, 2025): Hi, @webfiltered. I'm [Dosu](https://dosu.dev), and I'm helping the desktop team manage their backlog. I'm marking this issue as stale. **Issue Summary:** - The issue involves removing duplicate methods from the VirtualEnvironment. - These duplicates were introduced during a merge conflict resolution. - The aim is to refactor the code for a consistent API across tasks or virtual environment installations. - There have been no comments or activity since the issue was opened. **Next Steps:** - Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here. - If there is no further activity, the issue will be automatically closed in 7 days. Thank you for your understanding and contribution!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#222
No description provided.