[GH-ISSUE #1104] [DevTask] Convert electronAPI.restartAndInstall to invoke/handle #301

Closed
opened 2026-10-31 22:11:20 +00:00 by bsakaguchi · 1 comment
Owner

Originally created by @webfiltered on GitHub (Apr 20, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1104

Originally assigned to: @benceruleanlu on GitHub.

#1097 adds an API method restartAndInstall, which catches errors and logs to console. If the ToDesktop code does not show an error popup, the UX if an error occurs is that the button appears to do nothing at all.

This can be updated to invoke/handle, with supporting frontend code to e.g. show a toast.

┆Issue is synchronized with this Notion page by Unito

Originally created by @webfiltered on GitHub (Apr 20, 2025). Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1104 Originally assigned to: @benceruleanlu on GitHub. #1097 adds an API method `restartAndInstall`, which catches errors and logs to console. If the ToDesktop code does not show an error popup, the UX if an error occurs is that the button appears to do nothing at all. This can be updated to invoke/handle, with supporting frontend code to e.g. show a toast. ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-1104-DevTask-Convert-electronAPI-restartAndInstall-to-invoke-handle-1db6d73d36508170923cd2e272aab97e) by [Unito](https://www.unito.io)
bsakaguchi 2026-10-31 22:11:20 +00:00
Author
Owner

@benceruleanlu commented on GitHub (May 2, 2025):

Thanks for pointing this out.

The linked PR removes logging and silent fails, in favor for the frontend handling these errors by logging and showing users a simplified toast:

  • Toast for update not available
  • Toast for update failed error
  • Toast for restart and install failed error
<!-- gh-comment-id:2846089599 --> @benceruleanlu commented on GitHub (May 2, 2025): Thanks for pointing this out. The linked PR removes logging and silent fails, in favor for the frontend handling these errors by logging and showing users a simplified toast: - Toast for update not available - Toast for update failed error - Toast for restart and install failed error
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/desktop#301
No description provided.