mirror of
https://github.com/Comfy-Org/desktop.git
synced 2026-11-04 23:47:43 +00:00
[GH-ISSUE #1104] [DevTask] Convert electronAPI.restartAndInstall to invoke/handle #301
Labels
No labels
area: desktop-app
Bounty
bug
bug-cop:answered
bug-cop:response-received
component: installer
component: preload
custom node
dependencies
Design
documentation
duplicate
enhancement
expected
frontend
good first issue
installation
Low-Priority
performance
Planned
platform: cross-platform
platform: windows
Potential Bug
Potential Bug
pull-request
question
refactor
Release
stale
User Support
V1
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Comfy-Org/desktop#301
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @webfiltered on GitHub (Apr 20, 2025).
Original GitHub issue: https://github.com/Comfy-Org/desktop/issues/1104
Originally assigned to: @benceruleanlu on GitHub.
#1097 adds an API method
restartAndInstall, which catches errors and logs to console. If the ToDesktop code does not show an error popup, the UX if an error occurs is that the button appears to do nothing at all.This can be updated to invoke/handle, with supporting frontend code to e.g. show a toast.
┆Issue is synchronized with this Notion page by Unito
@benceruleanlu commented on GitHub (May 2, 2025):
Thanks for pointing this out.
The linked PR removes logging and silent fails, in favor for the frontend handling these errors by logging and showing users a simplified toast: