[PR #13] [MERGED] robustify python environment installation #555

New issue

Closed

opened 2026-10-31 22:14:50 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:14:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/13
Author: @telamonian
Created: 9/7/2024
Status: ✅ Merged
Merged: 9/7/2024
Merged by: @telamonian

Base: main ← Head: robustify-python-install

📝 Commits (8)

5333ffd creates an INSTALLER record on correct installation of python env
e3de71a run linux and windows debug build CI on all pull requests and pushes to main
62910db add optional .env file to assets
da3bb7a use cpu-only assets build on linux and windows CI
b6a6a23 include everything in assets/ in resources of built app
bcdce39 removed redundant assets.sh script
c489bd8 trim trailing whitespace
5e2ed79 refactor promise.then() syntax to use await

📊 Changes

10 files changed (+94 additions, -72 deletions)

View changed files

📝 .github/actions/build/linux/app/action.yml (+2 -1)
📝 .github/actions/build/windows/app/action.yml (+4 -5)
📝 .github/workflows/debug_linux.yml (+4 -3)
📝 .github/workflows/debug_windows.yml (+5 -4)
📝 forge.config.ts (+1 -1)
📝 package.json (+4 -2)
➖ scripts/assets.sh (+0 -6)
➕ scripts/env.mjs (+7 -0)
📝 src/main.ts (+59 -50)
📝 yarn.lock (+8 -0)

📄 Description

This PR will help to ensure that users don't end up stuck with a non-functional python env

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/13 **Author:** [@telamonian](https://github.com/telamonian) **Created:** 9/7/2024 **Status:** ✅ Merged **Merged:** 9/7/2024 **Merged by:** [@telamonian](https://github.com/telamonian) **Base:** `main` ← **Head:** `robustify-python-install` --- ### 📝 Commits (8) - [`5333ffd`](https://github.com/Comfy-Org/desktop/commit/5333ffd559c5934a4741683c1ce4050d7061d5ae) creates an INSTALLER record on correct installation of python env - [`e3de71a`](https://github.com/Comfy-Org/desktop/commit/e3de71a92fa73ffdebdf3d772940035d653d12d9) run linux and windows debug build CI on all pull requests and pushes to main - [`62910db`](https://github.com/Comfy-Org/desktop/commit/62910db7ea780ce32b831d79d52929c008ae9445) add optional .env file to assets - [`da3bb7a`](https://github.com/Comfy-Org/desktop/commit/da3bb7a80503bc2107c97b78799237b63a200d9c) use cpu-only assets build on linux and windows CI - [`b6a6a23`](https://github.com/Comfy-Org/desktop/commit/b6a6a23f4bc5f80c881c4f526578dac24d5540d4) include everything in assets/ in resources of built app - [`bcdce39`](https://github.com/Comfy-Org/desktop/commit/bcdce396ef6414d34147b6698c8fa9026388d271) removed redundant `assets.sh` script - [`c489bd8`](https://github.com/Comfy-Org/desktop/commit/c489bd85c3eb765c02e59584136fce078f03d101) trim trailing whitespace - [`5e2ed79`](https://github.com/Comfy-Org/desktop/commit/5e2ed796fb30d26d73de6a2b90ca65fe0271f0cf) refactor `promise.then()` syntax to use `await` ### 📊 Changes **10 files changed** (+94 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/linux/app/action.yml` (+2 -1) 📝 `.github/actions/build/windows/app/action.yml` (+4 -5) 📝 `.github/workflows/debug_linux.yml` (+4 -3) 📝 `.github/workflows/debug_windows.yml` (+5 -4) 📝 `forge.config.ts` (+1 -1) 📝 `package.json` (+4 -2) ➖ `scripts/assets.sh` (+0 -6) ➕ `scripts/env.mjs` (+7 -0) 📝 `src/main.ts` (+59 -50) 📝 `yarn.lock` (+8 -0) </details> ### 📄 Description This PR will help to ensure that users don't end up stuck with a non-functional python env --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:14:51 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:08 +00:00

[PR #555] [MERGED] Improve install path selection UX #932

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#555

No description provided.

Rows
Columns