[PR #555] [MERGED] Improve install path selection UX #932

New issue

Closed

opened 2026-10-31 22:18:08 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/555
Author: @webfiltered
Created: 12/24/2024
Status: ✅ Merged
Merged: 12/24/2024
Merged by: @huchenlei

Base: main ← Head: use-existing-path

📝 Commits (10+)

f6ca7b9 app-state
733d1ef nit
b252aa8 Remove type assertions - inline single-use getters
07254a0 nit
f108eaf Allow any install path, incl. existing
9dfe0b4 Add Electron types for path validation update
c57c90f Update test expectations
273251c Revert ES module extension in type publish script
09004b6 Update electron API - package.json type module
0d73510 Ensure documents folder exists when running CI

📊 Changes

8 files changed (+75 additions, -62 deletions)

View changed files

📝 scripts/prepareTypes.js (+3 -2)
📝 src/config/comfyConfigManager.ts (+0 -7)
📝 src/handlers/pathHandlers.ts (+30 -24)
📝 src/install/installWizard.ts (+12 -22)
📝 src/install/installationManager.ts (+7 -2)
📝 src/main.ts (+2 -1)
📝 src/preload.ts (+18 -1)
📝 tests/unit/comfyConfigManager.test.ts (+3 -3)

📄 Description

ComfyUI is no longer forcefully appended to the install path selected by the user
- e.g. Installing to Documents/ComfyUI
- Old: Documents/ComfyUI/ComfyUI
- New: Documents/ComfyUI
Existing paths can be re-used
Paired with frontend commit INSERT_PR_HERE
- Electron API Types from this PR are required by the frontend PR
- Works without the frontend commit, but will not display a warning if the path exists

Default install screen - full install path is now shown in frontend:

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/555 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/24/2024 **Status:** ✅ Merged **Merged:** 12/24/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `use-existing-path` --- ### 📝 Commits (10+) - [`f6ca7b9`](https://github.com/Comfy-Org/desktop/commit/f6ca7b9cc677767c12a0070a9e10da94a5bc3030) app-state - [`733d1ef`](https://github.com/Comfy-Org/desktop/commit/733d1ef4fc6316395fd1a3791c4e61607fe98808) nit - [`b252aa8`](https://github.com/Comfy-Org/desktop/commit/b252aa87cf315e00230ae8c7c0674b0a4d312868) Remove type assertions - inline single-use getters - [`07254a0`](https://github.com/Comfy-Org/desktop/commit/07254a03f686673862e9ef577cc38376d41cabb5) nit - [`f108eaf`](https://github.com/Comfy-Org/desktop/commit/f108eaf0c18327923bc5ad29653a9ff149bf0600) Allow any install path, incl. existing - [`9dfe0b4`](https://github.com/Comfy-Org/desktop/commit/9dfe0b47af0db1af79c85221db106701140230dc) Add Electron types for path validation update - [`c57c90f`](https://github.com/Comfy-Org/desktop/commit/c57c90f4ff94a1f0213b268b93adf53e95f4bd48) Update test expectations - [`273251c`](https://github.com/Comfy-Org/desktop/commit/273251c459d0c545dc12e3f708ffc4baa074a099) Revert ES module extension in type publish script - [`09004b6`](https://github.com/Comfy-Org/desktop/commit/09004b6b29ae18446c7bf12ddb59c3945abc677c) Update electron API - package.json type module - [`0d73510`](https://github.com/Comfy-Org/desktop/commit/0d7351081c871789f90dbc257bfbf25d6687c33f) Ensure documents folder exists when running CI ### 📊 Changes **8 files changed** (+75 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `scripts/prepareTypes.js` (+3 -2) 📝 `src/config/comfyConfigManager.ts` (+0 -7) 📝 `src/handlers/pathHandlers.ts` (+30 -24) 📝 `src/install/installWizard.ts` (+12 -22) 📝 `src/install/installationManager.ts` (+7 -2) 📝 `src/main.ts` (+2 -1) 📝 `src/preload.ts` (+18 -1) 📝 `tests/unit/comfyConfigManager.test.ts` (+3 -3) </details> ### 📄 Description - ComfyUI is no longer forcefully appended to the install path selected by the user - e.g. Installing to `Documents/ComfyUI` - Old: `Documents/ComfyUI/ComfyUI` - New: `Documents/ComfyUI` - Existing paths can be re-used - Paired with frontend commit INSERT_PR_HERE - Electron API Types from this PR are required by the frontend PR - Works without the frontend commit, but will not display a warning if the path exists Default install screen - full install path is now shown in frontend: ![image](https://github.com/user-attachments/assets/60342920-a98e-4dc3-8859-d3ce2a32d891) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-555-Improve-install-path-selection-UX-1666d73d36508181b406eef0da54bf98) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:08 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#932

No description provided.

Rows
Columns