[PR #147] [MERGED] Toggle auto-update and restart app for Electron settings. #643

New issue

Closed

opened 2026-10-31 22:15:32 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/147
Author: @robinjhuang
Created: 10/30/2024
Status: ✅ Merged
Merged: 10/30/2024
Merged by: @robinjhuang

Base: main ← Head: rh-settings

📝 Commits (4)

3c28570 Restart app on change.
aa2f574 Remove auto update IPC call.
4bb1c8a Add issue for hack.
7e5b735 Use https git url instead of SSH for CI.

📊 Changes

6 files changed (+130 additions, -99 deletions)

View changed files

➖ assets/ComfyUI_electron_adapter/__init__.py (+0 -1)
➖ assets/ComfyUI_electron_adapter/js/electronAdapter.js (+0 -39)
📝 package.json (+5 -4)
➕ src/config/comfySettings.ts (+60 -0)
📝 src/main.ts (+61 -51)
📝 src/preload.ts (+4 -4)

📄 Description

Disable auto updates if the value is false in the user settings.

Moved the settings frontend extension to its own repo. https://github.com/Comfy-Org/DesktopSettingsExtension

Will add crash statistics one in another PR: https://github.com/Comfy-Org/electron/issues/148

Remove restarting app flag once frontend bug is fixed: https://github.com/Comfy-Org/electron/issues/149

Closes #108. Closes https://github.com/Comfy-Org/electron/issues/134

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/147 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-settings` --- ### 📝 Commits (4) - [`3c28570`](https://github.com/Comfy-Org/desktop/commit/3c285705ead12ce01b2950e490b37993bbc2a501) Restart app on change. - [`aa2f574`](https://github.com/Comfy-Org/desktop/commit/aa2f57425836caf4fe20be75eb49234d9ad17c84) Remove auto update IPC call. - [`4bb1c8a`](https://github.com/Comfy-Org/desktop/commit/4bb1c8a7e3b5a79f908cb03f4a8a2940252dfe2b) Add issue for hack. - [`7e5b735`](https://github.com/Comfy-Org/desktop/commit/7e5b735e37707fbfc3fd8f04837064c9a723308a) Use https git url instead of SSH for CI. ### 📊 Changes **6 files changed** (+130 additions, -99 deletions) <details> <summary>View changed files</summary> ➖ `assets/ComfyUI_electron_adapter/__init__.py` (+0 -1) ➖ `assets/ComfyUI_electron_adapter/js/electronAdapter.js` (+0 -39) 📝 `package.json` (+5 -4) ➕ `src/config/comfySettings.ts` (+60 -0) 📝 `src/main.ts` (+61 -51) 📝 `src/preload.ts` (+4 -4) </details> ### 📄 Description Disable auto updates if the value is false in the user settings. Moved the settings frontend extension to its own repo. https://github.com/Comfy-Org/DesktopSettingsExtension Will add crash statistics one in another PR: https://github.com/Comfy-Org/electron/issues/148 Remove restarting app flag once frontend bug is fixed: https://github.com/Comfy-Org/electron/issues/149 Closes #108. Closes https://github.com/Comfy-Org/electron/issues/134 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:32 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:33 +00:00

[PR #643] [MERGED] Remove linux CI operations. #987

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#643

No description provided.

Rows
Columns