[PR #198] [MERGED] Refactor determine resource paths. #680

New issue

Closed

opened 2026-10-31 22:15:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:15:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/198
Author: @robinjhuang
Created: 11/7/2024
Status: ✅ Merged
Merged: 11/9/2024
Merged by: @robinjhuang

Base: main ← Head: rh-ref

📝 Commits (2)

677d804 Refactor determine resource paths.
6fc8c24 Add test.

📊 Changes

5 files changed (+164 additions, -40 deletions)

View changed files

📝 src/config/extra_model_config.ts (+1 -1)
➕ src/install/resourcePaths.ts (+24 -0)
📝 src/main.ts (+10 -36)
📝 tests/unit/extra_model_config.test.ts (+43 -3)
➕ tests/unit/install/resourcePath.test.ts (+86 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/198 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 11/7/2024 **Status:** ✅ Merged **Merged:** 11/9/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-ref` --- ### 📝 Commits (2) - [`677d804`](https://github.com/Comfy-Org/desktop/commit/677d804bcd1597326bf05d72c8592f3df1605ee3) Refactor determine resource paths. - [`6fc8c24`](https://github.com/Comfy-Org/desktop/commit/6fc8c248fca71492f6c28e202289aa0a40317323) Add test. ### 📊 Changes **5 files changed** (+164 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `src/config/extra_model_config.ts` (+1 -1) ➕ `src/install/resourcePaths.ts` (+24 -0) 📝 `src/main.ts` (+10 -36) 📝 `tests/unit/extra_model_config.test.ts` (+43 -3) ➕ `tests/unit/install/resourcePath.test.ts` (+86 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:15:56 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:18:49 +00:00

[PR #680] [CLOSED] Prevent custom window from being used #1017

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#680

No description provided.

Rows
Columns