[PR #268] [MERGED] Fixed: Error when user does not choose migration location #742

New issue

Closed

opened 2026-10-31 22:16:29 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:16:29 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/268
Author: @robinjhuang
Created: 11/15/2024
Status: ✅ Merged
Merged: 11/16/2024
Merged by: @huchenlei

Base: main ← Head: rh-bugfix2

📝 Commits (2)

eaed60b Hack: Return empty
f2001e0 Fix test.

📊 Changes

2 files changed (+5 additions, -3 deletions)

View changed files

📝 src/config/comfyServerConfig.ts (+2 -2)
📝 tests/unit/comfyServerConfig.test.ts (+3 -1)

📄 Description

If user doesn't choose a migration location, the getMigrationConfig returns an empty dictionary. But the caller depends on the comfyui key being there:

const { comfyui: comfyuiConfig, ...extraConfigs } = await ComfyServerConfig.getMigrationConfig(
    migrationSource,
    migrationItemIds
  );
  comfyuiConfig['base_path'] = actualComfyDirectory;

Updated the return type to make sure comfyui is in the return value.

17:02:52.116 › Created new ComfyUI config file at: /Users/junhanhuang/Desktop/ComfyUI/user/default/comfy.settings.json
This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
TypeError: Cannot set properties of undefined (setting 'base_path')
    at handleInstall (/Users/junhanhuang/Documents/electron/.vite/build/main.js:24636:30)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    ```

---

<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/268 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 11/15/2024 **Status:** ✅ Merged **Merged:** 11/16/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `rh-bugfix2` --- ### 📝 Commits (2) - [`eaed60b`](https://github.com/Comfy-Org/desktop/commit/eaed60b6a5e124f1b918f2885aff4064ac29fec6) Hack: Return empty - [`f2001e0`](https://github.com/Comfy-Org/desktop/commit/f2001e0ff60190faa2a96d7d69807e702ea4d1a0) Fix test. ### 📊 Changes **2 files changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/config/comfyServerConfig.ts` (+2 -2) 📝 `tests/unit/comfyServerConfig.test.ts` (+3 -1) </details> ### 📄 Description If user doesn't choose a migration location, the `getMigrationConfig` returns an empty dictionary. But the caller depends on the `comfyui` key being there: ``` const { comfyui: comfyuiConfig, ...extraConfigs } = await ComfyServerConfig.getMigrationConfig( migrationSource, migrationItemIds ); comfyuiConfig['base_path'] = actualComfyDirectory; ``` Updated the return type to make sure `comfyui` is in the return value. ``` 17:02:52.116 › Created new ComfyUI config file at: /Users/junhanhuang/Desktop/ComfyUI/user/default/comfy.settings.json This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason: TypeError: Cannot set properties of undefined (setting 'base_path') at handleInstall (/Users/junhanhuang/Documents/electron/.vite/build/main.js:24636:30) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:16:29 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:19:13 +00:00

[PR #744] [MERGED] Change default torch to cuda 12.4 #1064

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#742

No description provided.

Rows
Columns