[PR #291] [MERGED] Revert "Terminal commands" #761

New issue

Closed

opened 2026-10-31 22:16:40 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:16:40 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/291
Author: @robinjhuang
Created: 11/19/2024
Status: ✅ Merged
Merged: 11/19/2024
Merged by: @robinjhuang

Base: main ← Head: revert-237-terminal-commands

📝 Commits (1)

ba05662 Revert "Terminal commands (#237)"

📊 Changes

9 files changed (+6 additions, -215 deletions)

View changed files

📝 README.md (+0 -22)
📝 builder-debug.config.ts (+0 -1)
📝 package.json (+1 -3)
📝 src/constants.ts (+0 -4)
📝 src/main-process/comfyDesktopApp.ts (+1 -18)
📝 src/main.ts (+2 -0)
📝 src/preload.ts (+0 -34)
➖ src/terminal.ts (+0 -67)
📝 yarn.lock (+2 -66)

📄 Description

Reverts Comfy-Org/electron#237 because it breaks builds on to-desktop.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/291 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 11/19/2024 **Status:** ✅ Merged **Merged:** 11/19/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `revert-237-terminal-commands` --- ### 📝 Commits (1) - [`ba05662`](https://github.com/Comfy-Org/desktop/commit/ba056623ec2af36e6eb2c5ed36f89da7bb5d419d) Revert "Terminal commands (#237)" ### 📊 Changes **9 files changed** (+6 additions, -215 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+0 -22) 📝 `builder-debug.config.ts` (+0 -1) 📝 `package.json` (+1 -3) 📝 `src/constants.ts` (+0 -4) 📝 `src/main-process/comfyDesktopApp.ts` (+1 -18) 📝 `src/main.ts` (+2 -0) 📝 `src/preload.ts` (+0 -34) ➖ `src/terminal.ts` (+0 -67) 📝 `yarn.lock` (+2 -66) </details> ### 📄 Description Reverts Comfy-Org/electron#237 because it breaks builds on to-desktop. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:16:40 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#761

No description provided.

Rows
Columns