[PR #357] [MERGED] Pre-bundle requirements.compiled #815

New issue

Closed

opened 2026-10-31 22:17:10 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/357
Author: @robinjhuang
Created: 11/26/2024
Status: ✅ Merged
Merged: 11/26/2024
Merged by: @robinjhuang

Base: main ← Head: rh-downloadfe

📝 Commits (10+)

5910bba Take build logs.
1cbac2c Changes.
5818aa7 Use ubuntu.
45f3c9d v0.3.14
8798e47 Fix.
389da2e Upload.
a191cb8 Upload windows requirements.
cbb744d Remove .git.
56a7a99 Redact usernames.
3ea90a7 Fix requirements .

📊 Changes

12 files changed (+710 additions, -80 deletions)

View changed files

📝 .github/actions/build/linux/app/action.yml (+0 -1)
📝 .github/actions/build/windows/app/action.yml (+0 -1)
📝 .github/actions/build/windows/todesktop/action.yml (+16 -5)
📝 .github/workflows/publish_all.yml (+1 -1)
📝 README.md (+1 -0)
➕ assets/requirements/macos.compiled (+334 -0)
➕ assets/requirements/windows_nvidia.compiled (+341 -0)
📝 package.json (+3 -5)
📝 scripts/makeComfy.js (+7 -5)
➖ scripts/todesktop/postInstall.js (+0 -58)
📝 src/virtualEnvironment.ts (+5 -1)
📝 todesktop.json (+2 -3)

📄 Description

Moves most of the build process to be off to-desktop's servers and be platform independent.

Requirements.compiled are stored in the repo now. This lets us review changes before shipping them out.
Avoid doing comfy-cli install commands on Todesktop where the logs are often missing and can be more flakey
Builds are faster now since they are done on ubuntu instead of Windows runners.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/357 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 11/26/2024 **Status:** ✅ Merged **Merged:** 11/26/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `rh-downloadfe` --- ### 📝 Commits (10+) - [`5910bba`](https://github.com/Comfy-Org/desktop/commit/5910bba8fd0bd76661b6484111637e8bb385fd59) Take build logs. - [`1cbac2c`](https://github.com/Comfy-Org/desktop/commit/1cbac2cbb1130a2413218b1283152fc0a3aa9f5f) Changes. - [`5818aa7`](https://github.com/Comfy-Org/desktop/commit/5818aa707cb85f6faa6aaebf64960b16f7025610) Use ubuntu. - [`45f3c9d`](https://github.com/Comfy-Org/desktop/commit/45f3c9d1506e6f12b713d5125e7b1dfec876015a) v0.3.14 - [`8798e47`](https://github.com/Comfy-Org/desktop/commit/8798e4792873010344d1471e1eed0629a2bb8101) Fix. - [`389da2e`](https://github.com/Comfy-Org/desktop/commit/389da2edc70e850e9d2b50086829bb780f03b250) Upload. - [`a191cb8`](https://github.com/Comfy-Org/desktop/commit/a191cb8a28571f4ccd16ccda33e0ef4e661452d6) Upload windows requirements. - [`cbb744d`](https://github.com/Comfy-Org/desktop/commit/cbb744dd9625bb63f64645d6b645b8884e335cb8) Remove .git. - [`56a7a99`](https://github.com/Comfy-Org/desktop/commit/56a7a994f6f71f0cbda37918bc5129a04174687f) Redact usernames. - [`3ea90a7`](https://github.com/Comfy-Org/desktop/commit/3ea90a7ae32529736f35291ef01959bb2495eaf4) Fix requirements . ### 📊 Changes **12 files changed** (+710 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/build/linux/app/action.yml` (+0 -1) 📝 `.github/actions/build/windows/app/action.yml` (+0 -1) 📝 `.github/actions/build/windows/todesktop/action.yml` (+16 -5) 📝 `.github/workflows/publish_all.yml` (+1 -1) 📝 `README.md` (+1 -0) ➕ `assets/requirements/macos.compiled` (+334 -0) ➕ `assets/requirements/windows_nvidia.compiled` (+341 -0) 📝 `package.json` (+3 -5) 📝 `scripts/makeComfy.js` (+7 -5) ➖ `scripts/todesktop/postInstall.js` (+0 -58) 📝 `src/virtualEnvironment.ts` (+5 -1) 📝 `todesktop.json` (+2 -3) </details> ### 📄 Description Moves most of the build process to be off to-desktop's servers and be platform independent. 1. Requirements.compiled are stored in the repo now. This lets us review changes before shipping them out. 2. Avoid doing comfy-cli install commands on Todesktop where the logs are often missing and can be more flakey 3. Builds are faster now since they are done on ubuntu instead of Windows runners. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:10 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#815

No description provided.

Rows
Columns