[PR #420] [MERGED] Limit access to core settings #858

New issue

Closed

opened 2026-10-31 22:17:31 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/420
Author: @webfiltered
Created: 12/4/2024
Status: ✅ Merged
Merged: 12/6/2024
Merged by: @robinjhuang

Base: main ← Head: limit-core-settings

📝 Commits (4)

b7f31e6 Remove unused code: settings set()
dad40b9 nit
55a3bea Add guards & async to core settings reader
664d8d8 nit

📊 Changes

2 files changed (+15 additions, -11 deletions)

View changed files

📝 src/config/comfySettings.ts (+13 -9)
📝 src/store/desktopConfig.ts (+2 -2)

📄 Description

Removes set method from the ComfyUI core settings reader
- Unused, and there is no write method so it seems misleading
Adds guards for permission / filesystem errors
Converts to async FS access

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/420 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/4/2024 **Status:** ✅ Merged **Merged:** 12/6/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `limit-core-settings` --- ### 📝 Commits (4) - [`b7f31e6`](https://github.com/Comfy-Org/desktop/commit/b7f31e6a575d72b52e08649a88701cfba3454cb1) Remove unused code: settings set() - [`dad40b9`](https://github.com/Comfy-Org/desktop/commit/dad40b9fd55d7087c0ce4028297f126e3927e256) nit - [`55a3bea`](https://github.com/Comfy-Org/desktop/commit/55a3bea147a75b83149b024c5b93906f99dab29b) Add guards & async to core settings reader - [`664d8d8`](https://github.com/Comfy-Org/desktop/commit/664d8d81d86fb5ddbf6bd9ebce549d30f34c6769) nit ### 📊 Changes **2 files changed** (+15 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/config/comfySettings.ts` (+13 -9) 📝 `src/store/desktopConfig.ts` (+2 -2) </details> ### 📄 Description - Removes `set` method from the ComfyUI core settings reader - Unused, and there is no write method so it seems misleading - Adds guards for permission / filesystem errors - Converts to async FS access --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:31 +00:00