[PR #440] [MERGED] Revert "Settings store" #868

New issue

Closed

opened 2026-10-31 22:17:36 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:36 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/440
Author: @robinjhuang
Created: 12/5/2024
Status: ✅ Merged
Merged: 12/5/2024
Merged by: @robinjhuang

Base: main ← Head: revert-362-settings-store

📝 Commits (1)

182f78a Revert "Settings store (#362)"

📊 Changes

7 files changed (+27 additions, -282 deletions)

View changed files

📝 scripts/resetInstall.js (+13 -41)
➖ src/install/installationValidator.ts (+0 -58)
📝 src/main-process/appWindow.ts (+4 -4)
📝 src/main-process/comfyDesktopApp.ts (+8 -46)
📝 src/main.ts (+1 -16)
➖ src/store/desktopConfig.ts (+0 -104)
📝 src/store/index.ts (+1 -13)

📄 Description

Reverts Comfy-Org/desktop#362
Screenshot 2024-12-05 at 1 18 27 PM

After clicking "Reinstall" on the Help Menu, this pop up appears continuously without a way to get past it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/440 **Author:** [@robinjhuang](https://github.com/robinjhuang) **Created:** 12/5/2024 **Status:** ✅ Merged **Merged:** 12/5/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `revert-362-settings-store` --- ### 📝 Commits (1) - [`182f78a`](https://github.com/Comfy-Org/desktop/commit/182f78a2f50f499225c72ebdd023b4277b018bf9) Revert "Settings store (#362)" ### 📊 Changes **7 files changed** (+27 additions, -282 deletions) <details> <summary>View changed files</summary> 📝 `scripts/resetInstall.js` (+13 -41) ➖ `src/install/installationValidator.ts` (+0 -58) 📝 `src/main-process/appWindow.ts` (+4 -4) 📝 `src/main-process/comfyDesktopApp.ts` (+8 -46) 📝 `src/main.ts` (+1 -16) ➖ `src/store/desktopConfig.ts` (+0 -104) 📝 `src/store/index.ts` (+1 -13) </details> ### 📄 Description Reverts Comfy-Org/desktop#362 <img width="259" alt="Screenshot 2024-12-05 at 1 18 27 PM" src="https://github.com/user-attachments/assets/6d995991-3550-439f-a771-c5e6f741df36"> After clicking "Reinstall" on the Help Menu, this pop up appears continuously without a way to get past it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:36 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:04 +00:00

[PR #868] [MERGED] Readme compiled reqs #1168

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#868

No description provided.

Rows
Columns