[PR #482] [MERGED] [Refactor] Improve separation of concerns / lifecycle #903

New issue

Closed

opened 2026-10-31 22:17:53 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:53 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/482
Author: @webfiltered
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/14/2024
Merged by: @huchenlei

Base: main ← Head: settings-lifecycle

📝 Commits (6)

91943b4 Remove unused code
eece20e Fix lifecycle - keep store simple
40a3f55 Improve config lifecycle, convert to basic locator
6522d51 Remove static accessor
7dd9df7 Add separation of concerns
f003223 nit - Doc

📊 Changes

5 files changed (+66 additions, -42 deletions)

View changed files

📝 src/main-process/appWindow.ts (+2 -2)
📝 src/main-process/comfyDesktopApp.ts (+15 -17)
📝 src/main.ts (+8 -5)
📝 src/store/desktopConfig.ts (+39 -17)
📝 src/store/index.ts (+2 -1)

📄 Description

Clean up - Part I

Improves separation of concerns in DesktopConfig
Refactors to use() pattern
Converts / removes static accessors

Intention is to require less future-effort. No libraries I checked use static classes for this kind of thing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/482 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `settings-lifecycle` --- ### 📝 Commits (6) - [`91943b4`](https://github.com/Comfy-Org/desktop/commit/91943b4c4e286f9f92c1b6cd62349eb67d405d7e) Remove unused code - [`eece20e`](https://github.com/Comfy-Org/desktop/commit/eece20eeb64700827a982763eabfdbddc7d2b097) Fix lifecycle - keep store simple - [`40a3f55`](https://github.com/Comfy-Org/desktop/commit/40a3f5568d6f355c336ac12ea4cab6861580527c) Improve config lifecycle, convert to basic locator - [`6522d51`](https://github.com/Comfy-Org/desktop/commit/6522d514f7250a3087045ebb87a4e14c04ccf195) Remove static accessor - [`7dd9df7`](https://github.com/Comfy-Org/desktop/commit/7dd9df7533cbe82685f7ebb59fe8784707803a51) Add separation of concerns - [`f003223`](https://github.com/Comfy-Org/desktop/commit/f003223e91ed0cfdb7fc17902c4ab7715e069eb1) nit - Doc ### 📊 Changes **5 files changed** (+66 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `src/main-process/appWindow.ts` (+2 -2) 📝 `src/main-process/comfyDesktopApp.ts` (+15 -17) 📝 `src/main.ts` (+8 -5) 📝 `src/store/desktopConfig.ts` (+39 -17) 📝 `src/store/index.ts` (+2 -1) </details> ### 📄 Description ### Clean up - Part I - Improves separation of concerns in `DesktopConfig` - Refactors to `use()` pattern - Converts / removes static accessors Intention is to require less future-effort. No libraries I checked use static classes for this kind of thing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:53 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:16 +00:00

[PR #903] [MERGED] [e2e] Fix regression in per-test timeout (60sec) #1192

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#903

No description provided.

Rows
Columns