[PR #484] [MERGED] Fix async not awaited #906

New issue

Closed

opened 2026-10-31 22:17:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:17:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/484
Author: @webfiltered
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/14/2024
Merged by: @huchenlei

Base: main ← Head: fix-await

📝 Commits (10+)

91943b4 Remove unused code
eece20e Fix lifecycle - keep store simple
40a3f55 Improve config lifecycle, convert to basic locator
6522d51 Remove static accessor
7dd9df7 Add separation of concerns
f003223 nit - Doc
58ad9b4 nit - Unused imports
c45e548 Fix async not awaited
84101ea Fix async not awaited
54b06c1 Fix async not awaited - then/catch

📊 Changes

9 files changed (+53 additions, -48 deletions)

View changed files

📝 src/handlers/appInfoHandlers.ts (+1 -1)
📝 src/install/installationValidator.ts (+1 -1)
📝 src/main-process/appWindow.ts (+4 -4)
📝 src/main-process/comfyDesktopApp.ts (+19 -15)
📝 src/main-process/comfyServer.ts (+13 -13)
📝 src/main.ts (+15 -11)
📝 src/preload.ts (+0 -1)
📝 src/store/desktopConfig.ts (+0 -1)
📝 src/virtualEnvironment.ts (+0 -1)

📄 Description

Clean up - Part II

Based on #482
Fixes most unawaited async calls
- Remaining unhandled promises are inside synchronous callbacks
- One solution is to just catch & report errors via API to frontend
Fixes use of async callbacks in functions that do not support async

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/484 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix-await` --- ### 📝 Commits (10+) - [`91943b4`](https://github.com/Comfy-Org/desktop/commit/91943b4c4e286f9f92c1b6cd62349eb67d405d7e) Remove unused code - [`eece20e`](https://github.com/Comfy-Org/desktop/commit/eece20eeb64700827a982763eabfdbddc7d2b097) Fix lifecycle - keep store simple - [`40a3f55`](https://github.com/Comfy-Org/desktop/commit/40a3f5568d6f355c336ac12ea4cab6861580527c) Improve config lifecycle, convert to basic locator - [`6522d51`](https://github.com/Comfy-Org/desktop/commit/6522d514f7250a3087045ebb87a4e14c04ccf195) Remove static accessor - [`7dd9df7`](https://github.com/Comfy-Org/desktop/commit/7dd9df7533cbe82685f7ebb59fe8784707803a51) Add separation of concerns - [`f003223`](https://github.com/Comfy-Org/desktop/commit/f003223e91ed0cfdb7fc17902c4ab7715e069eb1) nit - Doc - [`58ad9b4`](https://github.com/Comfy-Org/desktop/commit/58ad9b411430262fb21ac01d4b6c894911b04fd4) nit - Unused imports - [`c45e548`](https://github.com/Comfy-Org/desktop/commit/c45e548bbaa43656e2fc58131c067d85f64bde58) Fix async not awaited - [`84101ea`](https://github.com/Comfy-Org/desktop/commit/84101ea4a707188177485d55b1e185b354b64f0b) Fix async not awaited - [`54b06c1`](https://github.com/Comfy-Org/desktop/commit/54b06c1a1bc430fac77908afae66028def23e47b) Fix async not awaited - then/catch ### 📊 Changes **9 files changed** (+53 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `src/handlers/appInfoHandlers.ts` (+1 -1) 📝 `src/install/installationValidator.ts` (+1 -1) 📝 `src/main-process/appWindow.ts` (+4 -4) 📝 `src/main-process/comfyDesktopApp.ts` (+19 -15) 📝 `src/main-process/comfyServer.ts` (+13 -13) 📝 `src/main.ts` (+15 -11) 📝 `src/preload.ts` (+0 -1) 📝 `src/store/desktopConfig.ts` (+0 -1) 📝 `src/virtualEnvironment.ts` (+0 -1) </details> ### 📄 Description ### Clean up - Part II - Based on #482 - Fixes _most_ unawaited async calls - Remaining unhandled promises are inside synchronous callbacks - One solution is to just catch & report errors via API to frontend - Fixes use of async callbacks in functions that do not support async --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:17:55 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#906

No description provided.

Rows
Columns