[PR #536] [MERGED] Add ESLint & Update tooling #917

New issue

Closed

opened 2026-10-31 22:18:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:18:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/desktop/pull/536
Author: @webfiltered
Created: 12/18/2024
Status: ✅ Merged
Merged: 12/19/2024
Merged by: @robinjhuang

Base: main ← Head: build-tooling

📝 Commits (10+)

882f301 Add ESLint & Unicorn
bc6143f Update TypeScript
52d4a8f Update vite
9a08a02 Fix build process not type-checked
183f56b Update project to lint all files
294a2a5 Update tsconfig to match project use
d7da8cd Improve legibility of dense JSON files
78247fe Fix yarn start never stops
21cecd7 Allow JS scripts to be formatted
a30d9e5 nit

📊 Changes

22 files changed (+1100 additions, -442 deletions)

View changed files

➖ .eslintrc.json (+0 -18)
📝 .prettierrc (+9 -1)
📝 .vscode/launch.json (+9 -2)
➕ eslint.config.js (+64 -0)
📝 package.json (+11 -6)
📝 scripts/downloadFrontend.js (+3 -3)
📝 scripts/downloadUV.js (+4 -2)
📝 scripts/env.mjs (+1 -1)
📝 scripts/getPackage.js (+1 -1)
📝 scripts/launchdev.js (+62 -63)
📝 scripts/makeComfy.js (+1 -2)
📝 scripts/preMake.js (+8 -7)
📝 scripts/prepareTypes.js (+2 -2)
📝 scripts/releaseTypes.js (+3 -3)
📝 scripts/resetInstall.js (+4 -4)
📝 scripts/updateFrontend.js (+3 -3)
📝 tests/integration/startup.spec.ts (+20 -12)
📝 todesktop.json (+4 -1)
➕ tsconfig.build.json (+4 -0)
📝 tsconfig.json (+6 -3)

...and 2 more files

📄 Description

Features

Adds ESLint with unicorn plugin and baseline rules
- Applies ESLint auto fixes
Updates TypeScript to support ES2024
- Separates tsconfig into IDE and build files (default editor)
- Sets noEmit in the tsconfig - vite handles build
Updates vite
Allows formatting of js files in scripts/
Formats some of them

Bug fixes

Fixes type checking not performed on build
Fixes yarn start never exits unless manually interrupted - restarts debug app every file save / commit
Resolves #534

┆Issue is synchronized with this Notion page by Unito

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/desktop/pull/536 **Author:** [@webfiltered](https://github.com/webfiltered) **Created:** 12/18/2024 **Status:** ✅ Merged **Merged:** 12/19/2024 **Merged by:** [@robinjhuang](https://github.com/robinjhuang) **Base:** `main` ← **Head:** `build-tooling` --- ### 📝 Commits (10+) - [`882f301`](https://github.com/Comfy-Org/desktop/commit/882f301146cd66e66edcd9aa23148bc7ee648ab1) Add ESLint & Unicorn - [`bc6143f`](https://github.com/Comfy-Org/desktop/commit/bc6143f0473e6f01aee1601645d19bdf6522184b) Update TypeScript - [`52d4a8f`](https://github.com/Comfy-Org/desktop/commit/52d4a8fd9281858c09f4b5c04f4c5b5fae232742) Update vite - [`9a08a02`](https://github.com/Comfy-Org/desktop/commit/9a08a02c1280aa088e239dabee27dc3494714794) Fix build process not type-checked - [`183f56b`](https://github.com/Comfy-Org/desktop/commit/183f56b3fc37684d5acd5402037687f46c302e40) Update project to lint all files - [`294a2a5`](https://github.com/Comfy-Org/desktop/commit/294a2a51126297350245355ae06177c11a2f8093) Update tsconfig to match project use - [`d7da8cd`](https://github.com/Comfy-Org/desktop/commit/d7da8cd4e2ee6094ea298223772d72695648ad78) Improve legibility of dense JSON files - [`78247fe`](https://github.com/Comfy-Org/desktop/commit/78247fef53d086005177dc77a630d8c67cc8c9f6) Fix yarn start never stops - [`21cecd7`](https://github.com/Comfy-Org/desktop/commit/21cecd7e6e567275a44c8eb7b78227cc6d52e876) Allow JS scripts to be formatted - [`a30d9e5`](https://github.com/Comfy-Org/desktop/commit/a30d9e553019244e43cc99cedac42d5eaba89b93) nit ### 📊 Changes **22 files changed** (+1100 additions, -442 deletions) <details> <summary>View changed files</summary> ➖ `.eslintrc.json` (+0 -18) 📝 `.prettierrc` (+9 -1) 📝 `.vscode/launch.json` (+9 -2) ➕ `eslint.config.js` (+64 -0) 📝 `package.json` (+11 -6) 📝 `scripts/downloadFrontend.js` (+3 -3) 📝 `scripts/downloadUV.js` (+4 -2) 📝 `scripts/env.mjs` (+1 -1) 📝 `scripts/getPackage.js` (+1 -1) 📝 `scripts/launchdev.js` (+62 -63) 📝 `scripts/makeComfy.js` (+1 -2) 📝 `scripts/preMake.js` (+8 -7) 📝 `scripts/prepareTypes.js` (+2 -2) 📝 `scripts/releaseTypes.js` (+3 -3) 📝 `scripts/resetInstall.js` (+4 -4) 📝 `scripts/updateFrontend.js` (+3 -3) 📝 `tests/integration/startup.spec.ts` (+20 -12) 📝 `todesktop.json` (+4 -1) ➕ `tsconfig.build.json` (+4 -0) 📝 `tsconfig.json` (+6 -3) _...and 2 more files_ </details> ### 📄 Description Features * Adds ESLint with unicorn plugin and baseline rules * Applies ESLint auto fixes * Updates TypeScript to support ES2024 * Separates tsconfig into IDE and build files (default editor) * Sets noEmit in the tsconfig - vite handles build * Updates vite * Allows formatting of js files in scripts/ * Formats some of them Bug fixes * Fixes type checking not performed on build * Fixes yarn start never exits unless manually interrupted - restarts debug app every file save / commit * Resolves #534 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-536-Add-ESLint-Update-tooling-1606d73d365081babb16f3c32fbe14d9) by [Unito](https://www.unito.io) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:18:01 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 22:20:24 +00:00

[PR #918] [MERGED] [CI] Prevent unnecessary workflow runs #1204

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/desktop#917

No description provided.

Rows
Columns