[PR #10] [CLOSED] ci: run download collection on Node 26 #10

New issue

Closed

opened 2026-10-26 22:08:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:08:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/download-data/pull/10
Author: @benceruleanlu
Created: 9/29/2026
Status: ❌ Closed

Base: main ← Head: chore/node-runtime-refresh-2026-09-28

📝 Commits (1)

11abded ci: run download collection on Node 26

📊 Changes

3 files changed (+97 additions, -247 deletions)

View changed files

📝 .github/workflows/fetch-data.yml (+3 -3)
📝 package.json (+2 -1)
📝 pnpm-lock.yaml (+92 -243)

📄 Description

Run the scheduled data-fetch job on Node 26 instead of the moving lts/* selector, which currently resolves to Node 24. Refresh checkout/setup-node to v7.

Upgrade better-sqlite3 from 12.4.1 to 13.0.3 for Node 26-compatible bundled native binaries. Add node-gyp explicitly for pnpm 10’s implicit native-package install step, and update only the affected lockfile dependency graph.

Validation on Node 26.10.0: frozen install, SQLite transaction/write/read round-trip, typecheck, lint, production build, actionlint, and git diff --check passed. A clean Linux container install with Python/build tools and SQLite round-trip also passed. Existing unrelated lockfile package metadata is unchanged.

The scheduled fetch-and-commit job was not dispatched; validation did not change the download database or push generated data.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/download-data/pull/10 **Author:** [@benceruleanlu](https://github.com/benceruleanlu) **Created:** 9/29/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `chore/node-runtime-refresh-2026-09-28` --- ### 📝 Commits (1) - [`11abded`](https://github.com/Comfy-Org/download-data/commit/11abded93df81ee7de616d3f01c78a422c33fdc2) ci: run download collection on Node 26 ### 📊 Changes **3 files changed** (+97 additions, -247 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/fetch-data.yml` (+3 -3) 📝 `package.json` (+2 -1) 📝 `pnpm-lock.yaml` (+92 -243) </details> ### 📄 Description Run the scheduled data-fetch job on Node 26 instead of the moving `lts/*` selector, which currently resolves to Node 24. Refresh checkout/setup-node to v7. Upgrade better-sqlite3 from 12.4.1 to 13.0.3 for Node 26-compatible bundled native binaries. Add node-gyp explicitly for pnpm 10’s implicit native-package install step, and update only the affected lockfile dependency graph. Validation on Node 26.10.0: frozen install, SQLite transaction/write/read round-trip, typecheck, lint, production build, actionlint, and git diff --check passed. A clean Linux container install with Python/build tools and SQLite round-trip also passed. Existing unrelated lockfile package metadata is unchanged. The scheduled fetch-and-commit job was not dispatched; validation did not change the download database or push generated data. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:08:28 +00:00