[PR #130] [CLOSED] fix: correct DYNAMIC_COMBO data type variants in existing node docs #130

New issue

Closed

opened 2026-10-26 22:09:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:09:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/embedded-docs/pull/130
Author: @lin-bot23
Created: 8/15/2026
Status: ❌ Closed

Base: main ← Head: fix/dynamic-combo-type-variants

📝 Commits (3)

b533387 fix: correct DYNAMIC_COMBO data type variants in existing node docs
f05b3b7 Merge branch 'main' into fix/dynamic-combo-type-variants
9fee1ca fix: complete DYNAMIC_COMBO coverage across all languages

📊 Changes

180 files changed (+306 additions, -350 deletions)

View changed files

📝 comfyui_embedded_docs/docs/BriaEraser/ar.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaEraser/en.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaEraser/es.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaEraser/fa.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaEraser/fr.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaEraser/ja.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaEraser/ko.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaEraser/pt-BR.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaEraser/ru.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaEraser/tr.md (+8 -13)
📝 comfyui_embedded_docs/docs/BriaEraser/zh-TW.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaEraser/zh.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaExpandImage/ar.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaExpandImage/en.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaExpandImage/es.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaExpandImage/fa.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaExpandImage/fr.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaExpandImage/ja.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaExpandImage/ko.md (+2 -2)
📝 comfyui_embedded_docs/docs/BriaExpandImage/pt-BR.md (+2 -2)

...and 80 more files

📄 Description

Summary

Normalizes incorrect data type spellings on DynamicCombo inputs in 15 existing node docs, verified against ComfyUI source schemas (comfy_api_nodes/nodes_bria.py, nodes_elevenlabs.py):

DYNAMICCOMBO (no underscore) → DYNAMIC_COMBO — zero residue repo-wide
DYNAMIC COMBO (space) → DYNAMIC_COMBO
Plain COMBO/STRING on IO.DynamicCombo.Input params → DYNAMIC_COMBO
Plain Combo inputs (e.g. BriaImageEditNode model, ViduMultiFrameVideoNode model) are correctly kept as COMBO

Nodes

BriaEraser, BriaExpandImage, BriaIncreaseResolution, ColorTransfer, ElevenLabsSpeechToSpeech, ElevenLabsSpeechToText, ElevenLabsTextToDialogue, ElevenLabsTextToSpeech, HitPawVideoEnhance, MagnificImageRelightNode, MeshyImageToModelNode, MeshyTextToModelNode, QuiverImageToSVGNode, TencentImageToModelNode, TencentTextToModelNode

Review follow-ups (commits `f05b3b7`, `9fee1ca`)

Merge conflict resolution: ElevenLabsSpeechToSpeech/fa.md + ja.md — kept main's newer source-aligned wording (incl. localized Required columns), applied the type fix on top. Source fingerprints match main.
Complete cross-language coverage: the original commit only fixed tr.md for 4 nodes; now BriaEraser (mask_type STRING→COMBO, moderation STRING→DYNAMIC_COMBO), BriaExpandImage (expand_mode, moderation), BriaIncreaseResolution (moderation), and ElevenLabsSpeechToText (model) are fixed in all 12 languages, including ru.md files using the Входные параметры heading and languages with localized parameter names.
Localized type cells normalized: HitPawVideoEnhance/ar, Meshy{Image,Text}ToModelNode/{es,fr,pt-BR,ar} used translated type names (e.g. COMBO DYNAMIQUE, قائمة منسدلة ديناميكية) — normalized to canonical English spellings per doc_rules.
Removed 以下が翻訳結果です。 AI-artifact lines from 7 ja.md files.

Verification

All 15 nodes: identical type sequences across all 12 languages, matching node source schemas
ElevenLabs + Bria nodes spot-checked line-by-line against current ComfyUI master source
ElevenLabsTextToDialogue.model (IO.Combo.Input, options=["eleven_v3"]) correctly stays COMBO; inputs (IO.DynamicCombo.Input) is DYNAMIC_COMBO

Note: a repo-wide sweep found pre-existing localized type values in nodes outside this PR's scope (e.g. BasicScheduler, ControlNetApply). Those predate this PR and are intentionally left for a separate cleanup.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/embedded-docs/pull/130 **Author:** [@lin-bot23](https://github.com/lin-bot23) **Created:** 8/15/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/dynamic-combo-type-variants` --- ### 📝 Commits (3) - [`b533387`](https://github.com/Comfy-Org/embedded-docs/commit/b5333877f98b3be37cad2f2d08bdc1393fe1e5e0) fix: correct DYNAMIC_COMBO data type variants in existing node docs - [`f05b3b7`](https://github.com/Comfy-Org/embedded-docs/commit/f05b3b70ecd3f6cfb4cb50239aa425567b0e89b8) Merge branch 'main' into fix/dynamic-combo-type-variants - [`9fee1ca`](https://github.com/Comfy-Org/embedded-docs/commit/9fee1ca8db5f22469268b0ae87e69cef41fa35e3) fix: complete DYNAMIC_COMBO coverage across all languages ### 📊 Changes **180 files changed** (+306 additions, -350 deletions) <details> <summary>View changed files</summary> 📝 `comfyui_embedded_docs/docs/BriaEraser/ar.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaEraser/en.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaEraser/es.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaEraser/fa.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaEraser/fr.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaEraser/ja.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaEraser/ko.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaEraser/pt-BR.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaEraser/ru.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaEraser/tr.md` (+8 -13) 📝 `comfyui_embedded_docs/docs/BriaEraser/zh-TW.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaEraser/zh.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaExpandImage/ar.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaExpandImage/en.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaExpandImage/es.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaExpandImage/fa.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaExpandImage/fr.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaExpandImage/ja.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaExpandImage/ko.md` (+2 -2) 📝 `comfyui_embedded_docs/docs/BriaExpandImage/pt-BR.md` (+2 -2) _...and 80 more files_ </details> ### 📄 Description ## Summary Normalizes incorrect data type spellings on DynamicCombo inputs in 15 existing node docs, verified against ComfyUI source schemas (`comfy_api_nodes/nodes_bria.py`, `nodes_elevenlabs.py`): - `DYNAMICCOMBO` (no underscore) → `DYNAMIC_COMBO` — zero residue repo-wide - `DYNAMIC COMBO` (space) → `DYNAMIC_COMBO` - Plain `COMBO`/`STRING` on `IO.DynamicCombo.Input` params → `DYNAMIC_COMBO` - Plain Combo inputs (e.g. BriaImageEditNode model, ViduMultiFrameVideoNode model) are correctly kept as `COMBO` ## Nodes BriaEraser, BriaExpandImage, BriaIncreaseResolution, ColorTransfer, ElevenLabsSpeechToSpeech, ElevenLabsSpeechToText, ElevenLabsTextToDialogue, ElevenLabsTextToSpeech, HitPawVideoEnhance, MagnificImageRelightNode, MeshyImageToModelNode, MeshyTextToModelNode, QuiverImageToSVGNode, TencentImageToModelNode, TencentTextToModelNode ## Review follow-ups (commits f05b3b7, 9fee1ca) - **Merge conflict resolution**: ElevenLabsSpeechToSpeech/fa.md + ja.md — kept main's newer source-aligned wording (incl. localized Required columns), applied the type fix on top. Source fingerprints match main. - **Complete cross-language coverage**: the original commit only fixed tr.md for 4 nodes; now BriaEraser (`mask_type` STRING→COMBO, `moderation` STRING→DYNAMIC_COMBO), BriaExpandImage (`expand_mode`, `moderation`), BriaIncreaseResolution (`moderation`), and ElevenLabsSpeechToText (`model`) are fixed in all 12 languages, including ru.md files using the `Входные параметры` heading and languages with localized parameter names. - **Localized type cells normalized**: HitPawVideoEnhance/ar, Meshy{Image,Text}ToModelNode/{es,fr,pt-BR,ar} used translated type names (e.g. `COMBO DYNAMIQUE`, `قائمة منسدلة ديناميكية`) — normalized to canonical English spellings per doc_rules. - Removed `以下が翻訳結果です。` AI-artifact lines from 7 ja.md files. ## Verification - All 15 nodes: identical type sequences across all 12 languages, matching node source schemas - ElevenLabs + Bria nodes spot-checked line-by-line against current ComfyUI master source - `ElevenLabsTextToDialogue.model` (`IO.Combo.Input`, options=["eleven_v3"]) correctly stays `COMBO`; `inputs` (`IO.DynamicCombo.Input`) is `DYNAMIC_COMBO` Note: a repo-wide sweep found pre-existing localized type values in nodes outside this PR's scope (e.g. BasicScheduler, ControlNetApply). Those predate this PR and are intentionally left for a separate cleanup. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:09:34 +00:00