[PR #198] [MERGED] Restore canonical doc folder names and drop pages for removed nodes #198

New issue

Closed

opened 2026-10-26 22:10:37 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:10:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/embedded-docs/pull/198
Author: @comfyui-wiki
Created: 10/22/2026
Status: ✅ Merged
Merged: 10/23/2026
Merged by: @comfyui-wiki

Base: main ← Head: fix/doc-folder-names

📝 Commits (1)

2491cd2 Restore canonical doc folder names and drop pages for removed nodes

📊 Changes

2175 files changed (+14924 additions, -43609 deletions)

View changed files

➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/ar.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/de.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/en.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/es.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/fa.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/fr.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/he.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/it.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/ja.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/ko.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/pt-BR.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/ru.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/tr.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/zh-TW.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowNamesTestNode/zh.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowPrefixTestNode/ar.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowPrefixTestNode/de.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowPrefixTestNode/en.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowPrefixTestNode/es.md (+0 -22)
➖ comfyui_embedded_docs/docs/AutogrowPrefixTestNode/fa.md (+0 -22)

...and 80 more files

📄 Description

What

Three kinds of folder-level drift accumulated in comfyui_embedded_docs/docs/. All three are invisible to content checks and to the per-file checkers, and all three make a node-id based scan of the docs produce wrong numbers.

1. 35 folders named from a title-cased spelling instead of the node id (renamed back with git mv)

docs/ClipLoader/ for node CLIPLoader, docs/VaeDecode/ for VAEDecode, docs/UnetLoader/ for UNETLoader, docs/SdTurboScheduler/, docs/GligenLoader/, docs/UnclipConditioning/, … Every acronym in the node id was lowercased. This changes those pages' URLs and makes a node-id based completeness check report the page as missing.

2. 65 folders documenting nodes that ComfyUI does not register (deleted, or renamed where the page is the only copy)

Removed upstream: Stability* (9), Pika* / Pikadditions|affects|swaps (7), KlingCameraControl* / Kling*VideoEffectNode / KlingVideoExtendNode / KlingVirtualTryOnNode (7), Moonvalley* (3), OpenAIDalle2|3 / OpenAIVideoSora2 (3), IdeogramV1|V2 (2), ByteDanceImage* v1 (3), FluxPro*ImageNode (3), LtxvApi* (2), VeoVideoGenerationNode, GeminiImage (superseded by GeminiImageNode*), TripoRefineNode.
Dead code / never registered: SetModelHooksOnCond (class exists in nodes_hooks.py but is not in node_list), RecraftStyleV3VectorIllustrationNode (not returned by get_node_list), DCTestNode, ComboOptionTestNode, Autogrow*TestNode, InvertBooleanNode, ComfySoftSwitchNode, ConvertStringToComboNode, MultiGPU_Options, DA3GeometryToPointCloud, MinimaxSubjectToVideoNode, BatchImagesMasksLatentsNode — the logic/dataset nodes whose registration is commented out in get_node_list.
Renamed instead of deleted (the page is the only documentation of the same node): CombineHooks → CombineHooks2, CombineHooksFour → CombineHooks4, CombineHooksEight → CombineHooks8, ConditioningSetDefaultAndCombine → ConditioningSetDefaultCombine, PairConditioningSetDefaultAndCombine → PairConditioningSetDefaultCombine.

3. 7 duplicate folders written under a sanitized spelling (deleted; the canonical folder stays)

SvdImg2vidConditioning vs SVD_img2vid_Conditioning, EpsilonScaling vs Epsilon Scaling, SamplerDpmppSde vs SamplerDPMPP_SDE, SamplerDpmpp2mSde, Sd4xupscaleConditioning, Stablezero123Conditioning, Stablezero123ConditioningBatched.

Pages with no backend class are untouched, because a Python-source scan cannot see them: frontend virtual nodes (Note, MarkdownNote, Reroute, PrimitiveNode, DeprecatedCheckpointLoader, DeprecatedDiffusersLoader), extension nodes (TerminalLog), and the reverted-core pages the scanner would otherwise call dead — SeedVR2ProgressiveSampler (added in #14110, reverted in #14359) and the comfy_extras/nodes_train.py family (LoadImageSetNode, LoadImageSetFromFolderNode, LoadImageTextSetFromFolderNode, SaveLoRANode), which are expected to come back. #197 lists them in config/non_backend_nodes.json grouped by reason.

Verification

Scanning the same tree with the tooling from #197:

	before	after
doc folders whose name ≠ node id	35	0
duplicate folders	7	0
folders for unregistered nodes	58	11 (all listed in `config/non_backend_nodes.json`)
nodes without docs	19	14 (5 Veed + 9 fixed by the scanner PR)

git status is clean, folder count goes 1061 → 996. The “Edit on GitHub” self link in the 40 renamed folders was rewritten in all 15 locales (600 files) so it points at the new path, and the repo checkers agree: check_md_format.py → 0 errors, 125 warnings (all pre-existing, e.g. missing fingerprint footers), check_doc_structure.py → 0 defects.

Notes

Deleting a page is reversible from history; URLs for the removed nodes were already dead (the node types no longer load in ComfyUI).
The title-cased names were produced by the daily generation step, not by hand — whatever writes a folder should take the node id verbatim. #197 makes this kind of drift visible in every scan.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/embedded-docs/pull/198 **Author:** [@comfyui-wiki](https://github.com/comfyui-wiki) **Created:** 10/22/2026 **Status:** ✅ Merged **Merged:** 10/23/2026 **Merged by:** [@comfyui-wiki](https://github.com/comfyui-wiki) **Base:** `main` ← **Head:** `fix/doc-folder-names` --- ### 📝 Commits (1) - [`2491cd2`](https://github.com/Comfy-Org/embedded-docs/commit/2491cd25b09d772d367021b95382d774c18c8df1) Restore canonical doc folder names and drop pages for removed nodes ### 📊 Changes **2175 files changed** (+14924 additions, -43609 deletions) <details> <summary>View changed files</summary> ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/ar.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/de.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/en.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/es.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/fa.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/fr.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/he.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/it.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/ja.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/ko.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/pt-BR.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/ru.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/tr.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/zh-TW.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowNamesTestNode/zh.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowPrefixTestNode/ar.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowPrefixTestNode/de.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowPrefixTestNode/en.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowPrefixTestNode/es.md` (+0 -22) ➖ `comfyui_embedded_docs/docs/AutogrowPrefixTestNode/fa.md` (+0 -22) _...and 80 more files_ </details> ### 📄 Description ## What Three kinds of folder-level drift accumulated in `comfyui_embedded_docs/docs/`. All three are invisible to content checks and to the per-file checkers, and all three make a node-id based scan of the docs produce wrong numbers. **1. 35 folders named from a title-cased spelling instead of the node id** (renamed back with `git mv`) `docs/ClipLoader/` for node `CLIPLoader`, `docs/VaeDecode/` for `VAEDecode`, `docs/UnetLoader/` for `UNETLoader`, `docs/SdTurboScheduler/`, `docs/GligenLoader/`, `docs/UnclipConditioning/`, … Every acronym in the node id was lowercased. This changes those pages' URLs and makes a node-id based completeness check report the page as missing. **2. 65 folders documenting nodes that ComfyUI does not register** (deleted, or renamed where the page is the only copy) - Removed upstream: `Stability*` (9), `Pika*` / `Pikadditions|affects|swaps` (7), `KlingCameraControl*` / `Kling*VideoEffectNode` / `KlingVideoExtendNode` / `KlingVirtualTryOnNode` (7), `Moonvalley*` (3), `OpenAIDalle2|3` / `OpenAIVideoSora2` (3), `IdeogramV1|V2` (2), `ByteDanceImage*` v1 (3), `FluxPro*ImageNode` (3), `LtxvApi*` (2), `VeoVideoGenerationNode`, `GeminiImage` (superseded by `GeminiImageNode*`), `TripoRefineNode`. - Dead code / never registered: `SetModelHooksOnCond` (class exists in `nodes_hooks.py` but is not in `node_list`), `RecraftStyleV3VectorIllustrationNode` (not returned by `get_node_list`), `DCTestNode`, `ComboOptionTestNode`, `Autogrow*TestNode`, `InvertBooleanNode`, `ComfySoftSwitchNode`, `ConvertStringToComboNode`, `MultiGPU_Options`, `DA3GeometryToPointCloud`, `MinimaxSubjectToVideoNode`, `BatchImagesMasksLatentsNode` — the logic/dataset nodes whose registration is commented out in `get_node_list`. - Renamed instead of deleted (the page is the only documentation of the same node): `CombineHooks` → `CombineHooks2`, `CombineHooksFour` → `CombineHooks4`, `CombineHooksEight` → `CombineHooks8`, `ConditioningSetDefaultAndCombine` → `ConditioningSetDefaultCombine`, `PairConditioningSetDefaultAndCombine` → `PairConditioningSetDefaultCombine`. **3. 7 duplicate folders written under a sanitized spelling** (deleted; the canonical folder stays) `SvdImg2vidConditioning` vs `SVD_img2vid_Conditioning`, `EpsilonScaling` vs `Epsilon Scaling`, `SamplerDpmppSde` vs `SamplerDPMPP_SDE`, `SamplerDpmpp2mSde`, `Sd4xupscaleConditioning`, `Stablezero123Conditioning`, `Stablezero123ConditioningBatched`. Pages with **no backend class** are untouched, because a Python-source scan cannot see them: frontend virtual nodes (`Note`, `MarkdownNote`, `Reroute`, `PrimitiveNode`, `DeprecatedCheckpointLoader`, `DeprecatedDiffusersLoader`), extension nodes (`TerminalLog`), and the **reverted-core** pages the scanner would otherwise call dead — `SeedVR2ProgressiveSampler` (added in #14110, reverted in #14359) and the `comfy_extras/nodes_train.py` family (`LoadImageSetNode`, `LoadImageSetFromFolderNode`, `LoadImageTextSetFromFolderNode`, `SaveLoRANode`), which are expected to come back. #197 lists them in `config/non_backend_nodes.json` grouped by reason. ## Verification Scanning the same tree with the tooling from #197: | | before | after | |---|---|---| | doc folders whose name ≠ node id | 35 | **0** | | duplicate folders | 7 | **0** | | folders for unregistered nodes | 58 | 11 (all listed in `config/non_backend_nodes.json`) | | nodes without docs | 19 | **14** (5 Veed + 9 fixed by the scanner PR) | `git status` is clean, folder count goes 1061 → 996. The “Edit on GitHub” self link in the 40 renamed folders was rewritten in all 15 locales (600 files) so it points at the new path, and the repo checkers agree: `check_md_format.py` → 0 errors, 125 warnings (all pre-existing, e.g. missing fingerprint footers), `check_doc_structure.py` → 0 defects. ## Notes - Deleting a page is reversible from history; URLs for the removed nodes were already dead (the node types no longer load in ComfyUI). - The title-cased names were produced by the daily generation step, not by hand — whatever writes a folder should take the node id verbatim. #197 makes this kind of drift visible in every scan. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:10:37 +00:00