[PR #337] fix(hygiene): recognize comfy-cli CODEOWNERS teams #336

New issue

Open

opened 2026-10-26 22:38:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:38:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/337
Author: @huntcsg
Created: 9/24/2026
Status: 🔄 Open

Base: main ← Head: chore/comfy-cli-codeowners-team-allowlist

📝 Commits (1)

e67b652 fix(hygiene): recognize comfy-cli CODEOWNERS teams

📊 Changes

1 file changed (+10 additions, -1 deletions)

View changed files

📝 .github/public-repo-hygiene/check_public_repo_hygiene.py (+10 -1)

📄 Description

The public CODEOWNERS proposal in comfy-cli #945 names @Comfy-Org/cloud-infra and @Comfy-Org/comfy-standard-approver. The hygiene checker reports 10 findings for those handles because its known-public team allowlist lacks both names. Add only these two team slugs, in sorted order; unknown teams still produce findings.

This is a companion draft. After merge, the normal hygiene caller pin rollout can deliver the entries to comfy-cli. The team write grants were configured separately for comfy-cli; its CODEOWNERS now passes GitHub owner validation.

Validation: all 204 hygiene unit tests and all 13 CI smoke steps pass. An integration fixture containing the exact proposed comfy-cli CODEOWNERS produces 10 findings before this change and zero afterward; adding an unknown team still fails. Workflow-pin validation, AGENTS.md integrity, org-repo literal lint and ShellCheck, and git diff --check pass (AGENTS.md integrity retains its existing length/no-CODEOWNERS warnings).

A full-tree scan of comfy-cli using the latest checker also found an unrelated existing NAME_MAX-14 docstring treated as a ticket ID. The two new allowlist entries clear all owner-handle findings; they do not suppress that separate finding.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/337 **Author:** [@huntcsg](https://github.com/huntcsg) **Created:** 9/24/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `chore/comfy-cli-codeowners-team-allowlist` --- ### 📝 Commits (1) - [`e67b652`](https://github.com/Comfy-Org/github-workflows/commit/e67b652e38bdb08b9e0aec2fa8b3102edd9afb82) fix(hygiene): recognize comfy-cli CODEOWNERS teams ### 📊 Changes **1 file changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/public-repo-hygiene/check_public_repo_hygiene.py` (+10 -1) </details> ### 📄 Description The public CODEOWNERS proposal in [comfy-cli #945](https://github.com/Comfy-Org/comfy-cli/pull/945) names `@Comfy-Org/cloud-infra` and `@Comfy-Org/comfy-standard-approver`. The hygiene checker reports 10 findings for those handles because its known-public team allowlist lacks both names. Add only these two team slugs, in sorted order; unknown teams still produce findings. This is a companion draft. After merge, the normal hygiene caller pin rollout can deliver the entries to comfy-cli. The team write grants were configured separately for comfy-cli; its CODEOWNERS now passes GitHub owner validation. Validation: all 204 hygiene unit tests and all 13 CI smoke steps pass. An integration fixture containing the exact proposed comfy-cli CODEOWNERS produces 10 findings before this change and zero afterward; adding an unknown team still fails. Workflow-pin validation, AGENTS.md integrity, org-repo literal lint and ShellCheck, and `git diff --check` pass (AGENTS.md integrity retains its existing length/no-CODEOWNERS warnings). A full-tree scan of comfy-cli using the latest checker also found an unrelated existing `NAME_MAX-14` docstring treated as a ticket ID. The two new allowlist entries clear all owner-handle findings; they do not suppress that separate finding. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-26 22:38:39 +00:00

bsakaguchi referenced this issue

2026-10-26 22:38:41 +00:00

[PR #336] [MERGED] ci(coderabbit-config): refresh the vendored CodeRabbit schema #340