[PR #336] [MERGED] ci(coderabbit-config): refresh the vendored CodeRabbit schema #340

New issue

Closed

opened 2026-10-26 22:38:41 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:38:41 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/github-workflows/pull/336
Author: @cloud-code-bot[bot]
Created: 9/21/2026
Status: ✅ Merged
Merged: 10/6/2026
Merged by: @mattmillerai

Base: main ← Head: ci/refresh-coderabbit-schema

📝 Commits (2)

b3b0037 ci(coderabbit-config): refresh the vendored CodeRabbit schema
b22252d test(coderabbit-config): re-sync the schema census with the vendored copy

📊 Changes

4 files changed (+52 additions, -31 deletions)

View changed files

📝 .github/coderabbit-config/README.md (+2 -2)
📝 .github/coderabbit-config/schema.v2.json (+37 -27)
📝 .github/coderabbit-config/tests/test_check_coderabbit_config.py (+6 -1)
📝 .github/coderabbit-config/tests/test_schema_drift.py (+7 -1)

📄 Description

Upstream's CodeRabbit config schema has drifted from the copy vendored here, which is what coderabbit-config-validate.yml grades every enrolled repo against.

Added properties (2):

reviews.allow_author_approval
reviews.tools.ast-grep.enabled

Before merging, check the tightened-cap section above if there is one: a lowered maxLength retroactively invalidates configs nobody has touched, and merging this makes their next PR red. Landing the cleanup alongside is usually the right order.

Note

Census assertions re-synced in b22252d. The two failures below were inherited from main (red since #250 / #288, identical counts on main and on this branch), not caused by this refresh: its two added properties are leaves. b22252d moves omitted 104 → 105 and caps 14 → 15 deliberately, pins the 15th cap's value (chat.integrations.jira.issue_template = 3000) and the documented 50 → 20,000 span, and updates README's cap count. The output below is the refresher's original run, kept for the record.

Warning

The invariant unit suite FAILS against the proposed schema (this run). That suite asserts the exact facts the checker's messages rest on, so this is the signal to read closely, not a flake: either the schema change is one we must adapt the checker and its tests to, or the fetch is not what we think it is. Update those assertions in this PR, deliberately, before merging.

Invariant suite output

...................................................................F.............................F.
======================================================================
FAIL: test_the_two_halves_partition_the_objects_that_declare_properties (test_check_coderabbit_config.OpennessTest.test_the_two_halves_partition_the_objects_that_declare_properties)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/github-workflows/github-workflows/.github/coderabbit-config/tests/test_check_coderabbit_config.py", line 1060, in test_the_two_halves_partition_the_objects_that_declare_properties
    self.assertEqual(len(omitted), 104)
AssertionError: 105 != 104

======================================================================
FAIL: test_the_committed_schema_has_the_documented_cap_set (test_schema_drift.VendoredSchemaTest.test_the_committed_schema_has_the_documented_cap_set)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/github-workflows/github-workflows/.github/coderabbit-config/tests/test_schema_drift.py", line 213, in test_the_committed_schema_has_the_documented_cap_set
    self.assertEqual(len(caps), 14)
AssertionError: 15 != 14

----------------------------------------------------------------------
Ran 99 tests in 2.034s

FAILED (failures=2)

Merging this touches .github/coderabbit-config/**, which triggers bump-coderabbit-config-callers.yml and rolls the SHA-pinned caller fleet forward.

Opened by the refresh-coderabbit-schema workflow.

Provenance

Verified: python3 -m unittest discover -s .github/coderabbit-config/tests -p 'test_*.py' — 99 tests OK on b22252d (2 census failures on b3b0037 and on main); check_agents_md.py --root . and check-org-repo-literals.sh pass.
Deviations: Test and README census updates added on top of the refresher's commit; the schema itself is unchanged from the refresh.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/github-workflows/pull/336 **Author:** [@cloud-code-bot[bot]](https://github.com/apps/cloud-code-bot) **Created:** 9/21/2026 **Status:** ✅ Merged **Merged:** 10/6/2026 **Merged by:** [@mattmillerai](https://github.com/mattmillerai) **Base:** `main` ← **Head:** `ci/refresh-coderabbit-schema` --- ### 📝 Commits (2) - [`b3b0037`](https://github.com/Comfy-Org/github-workflows/commit/b3b00375266a7fc4ae5678a853d4bbde3e8f25de) ci(coderabbit-config): refresh the vendored CodeRabbit schema - [`b22252d`](https://github.com/Comfy-Org/github-workflows/commit/b22252df146e55696e0c2cc2e46ba99620c31c2a) test(coderabbit-config): re-sync the schema census with the vendored copy ### 📊 Changes **4 files changed** (+52 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `.github/coderabbit-config/README.md` (+2 -2) 📝 `.github/coderabbit-config/schema.v2.json` (+37 -27) 📝 `.github/coderabbit-config/tests/test_check_coderabbit_config.py` (+6 -1) 📝 `.github/coderabbit-config/tests/test_schema_drift.py` (+7 -1) </details> ### 📄 Description Upstream's CodeRabbit config schema has drifted from the copy vendored here, which is what `coderabbit-config-validate.yml` grades every enrolled repo against. **Added properties** (2): - `reviews.allow_author_approval` - `reviews.tools.ast-grep.enabled` **Before merging**, check the tightened-cap section above if there is one: a lowered `maxLength` retroactively invalidates configs nobody has touched, and merging this makes their next PR red. Landing the cleanup alongside is usually the right order. > [!NOTE] > **Census assertions re-synced in b22252d.** The two failures below were inherited from main (red since #250 / #288, identical counts on main and on this branch), not caused by this refresh: its two added properties are leaves. b22252d moves `omitted` 104 → 105 and `caps` 14 → 15 deliberately, pins the 15th cap's value (`chat.integrations.jira.issue_template` = 3000) and the documented 50 → 20,000 span, and updates README's cap count. The output below is the refresher's original run, kept for the record. > [!WARNING] > **The invariant unit suite FAILS against the proposed schema** ([this run](https://github.com/Comfy-Org/github-workflows/actions/runs/37330419955)). That suite asserts the exact facts the checker's messages rest on, so this is the signal to read closely, not a flake: either the schema change is one we must adapt the checker and its tests to, or the fetch is not what we think it is. Update those assertions in this PR, deliberately, before merging. <details><summary>Invariant suite output</summary> ``` ...................................................................F.............................F. ====================================================================== FAIL: test_the_two_halves_partition_the_objects_that_declare_properties (test_check_coderabbit_config.OpennessTest.test_the_two_halves_partition_the_objects_that_declare_properties) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/runner/work/github-workflows/github-workflows/.github/coderabbit-config/tests/test_check_coderabbit_config.py", line 1060, in test_the_two_halves_partition_the_objects_that_declare_properties self.assertEqual(len(omitted), 104) AssertionError: 105 != 104 ====================================================================== FAIL: test_the_committed_schema_has_the_documented_cap_set (test_schema_drift.VendoredSchemaTest.test_the_committed_schema_has_the_documented_cap_set) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/runner/work/github-workflows/github-workflows/.github/coderabbit-config/tests/test_schema_drift.py", line 213, in test_the_committed_schema_has_the_documented_cap_set self.assertEqual(len(caps), 14) AssertionError: 15 != 14 ---------------------------------------------------------------------- Ran 99 tests in 2.034s FAILED (failures=2) ``` </details> Merging this touches `.github/coderabbit-config/**`, which triggers `bump-coderabbit-config-callers.yml` and rolls the SHA-pinned caller fleet forward. _Opened by the `refresh-coderabbit-schema` workflow._ ## Provenance **Verified:** `python3 -m unittest discover -s .github/coderabbit-config/tests -p 'test_*.py'` — 99 tests OK on b22252d (2 census failures on b3b0037 and on main); `check_agents_md.py --root .` and `check-org-repo-literals.sh` pass. **Deviations:** Test and README census updates added on top of the refresher's commit; the schema itself is unchanged from the refresh. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:38:41 +00:00