Comfy-Org/jpcosta-comfy-apps
1
0
Fork 0
mirror of https://github.com/Comfy-Org/jpcosta-comfy-apps.git synced 2026-11-05 06:47:20 +00:00
Code Issues Projects Packages Wiki Activity

[PR #19] [MERGED] fix(open-unboxing): composite the product, not its background #19

New issue
Closed
opened 2026-11-04 22:29:07 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-11-04 22:29:07 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/jpcosta-comfy-apps/pull/19
Author: @jpcosta-comfy
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @jpcosta-comfy

Base: main ← Head: fix/unboxing-mask-polarity

📝 Commits (1)

  • 63681d4 fix(open-unboxing): composite the product, not its background

📊 Changes

2 files changed (+1 additions, -11 deletions)

View changed files

📝 workflows/open-unboxing/README.md (+0 -1)
📝 workflows/open-unboxing/workflow_api.json (+1 -10)

📄 Description

RemoveBackground already emits a subject=1 mask. The InvertMask copied from the
background-removal app (where JoinImageWithAlpha needs it) flipped the mask, so
ImageCompositeMasked pasted the studio background and left a product-shaped
hole of well magenta. FLUX then invented a generic product.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/jpcosta-comfy-apps/pull/19 **Author:** [@jpcosta-comfy](https://github.com/jpcosta-comfy) **Created:** 10/21/2026 **Status:** ✅ Merged **Merged:** 10/21/2026 **Merged by:** [@jpcosta-comfy](https://github.com/jpcosta-comfy) **Base:** `main` ← **Head:** `fix/unboxing-mask-polarity` --- ### 📝 Commits (1) - [`63681d4`](https://github.com/Comfy-Org/jpcosta-comfy-apps/commit/63681d4e5afe95599993ea27396fd1670ac9d4df) fix(open-unboxing): composite the product, not its background ### 📊 Changes **2 files changed** (+1 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `workflows/open-unboxing/README.md` (+0 -1) 📝 `workflows/open-unboxing/workflow_api.json` (+1 -10) </details> ### 📄 Description RemoveBackground already emits a subject=1 mask. The InvertMask copied from the background-removal app (where JoinImageWithAlpha needs it) flipped the mask, so ImageCompositeMasked pasted the studio background and left a product-shaped hole of well magenta. FLUX then invented a generic product. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-11-04 22:29:07 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
cursor/migrate-open-apps-51e4
cursor/pumpkin-carve-seedance-2-ad9c
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/jpcosta-comfy-apps#19
No description provided.