Comfy-Org/pyisolate
1
0
Fork 0
mirror of https://github.com/Comfy-Org/pyisolate.git synced 2026-11-05 00:27:34 +00:00
Code Issues 2 Projects Packages Wiki Activity

[PR #20] [MERGED] fix: fail CLA allowlist step on API errors #20

New issue
Closed
opened 2026-10-26 22:11:38 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 22:11:38 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/pyisolate/pull/20
Author: @alexisrolland
Created: 8/21/2026
Status: ✅ Merged
Merged: 8/21/2026
Merged by: @alexisrolland

Base: main ← Head: fix/cla-api-failure-handling

📝 Commits (1)

  • dd16fa9 fix: fail CLA allowlist step on API errors

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 .github/workflows/cla.yml (+6 -3)

📄 Description

Summary

Make the CLA author allowlist step fail when its GitHub API request fails instead of silently continuing with only the base allowlist.

Changes

  • Capture the pull request commit API response before filtering authors.
  • Fail explicitly when the API request or pagination fails.
  • Preserve the valid author-only case where filtering produces no co-authors.

Verification

The shared implementation was validated for author-only, co-author, and simulated API-failure scenarios in Comfy-Org/comfy-cla.

Propagates Comfy-Org/comfy-cla#1 and addresses Comfy-Org/ComfyUI_frontend#15555.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/pyisolate/pull/20 **Author:** [@alexisrolland](https://github.com/alexisrolland) **Created:** 8/21/2026 **Status:** ✅ Merged **Merged:** 8/21/2026 **Merged by:** [@alexisrolland](https://github.com/alexisrolland) **Base:** `main` ← **Head:** `fix/cla-api-failure-handling` --- ### 📝 Commits (1) - [`dd16fa9`](https://github.com/Comfy-Org/pyisolate/commit/dd16fa98f46e49080bbee74ae1e87672b2133d96) fix: fail CLA allowlist step on API errors ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/cla.yml` (+6 -3) </details> ### 📄 Description ## Summary Make the CLA author allowlist step fail when its GitHub API request fails instead of silently continuing with only the base allowlist. ## Changes - Capture the pull request commit API response before filtering authors. - Fail explicitly when the API request or pagination fails. - Preserve the valid author-only case where filtering produces no co-authors. ## Verification The shared implementation was validated for author-only, co-author, and simulated API-failure scenarios in `Comfy-Org/comfy-cla`. Propagates Comfy-Org/comfy-cla#1 and addresses Comfy-Org/ComfyUI_frontend#15555. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 22:11:38 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
matt/be-3565-promote-claudemd-to-agentsmd
chore/node-runtime-refresh-2026-09-28
fix/cla-api-failure-handling
alexisrolland-patch-2
alexisrolland-patch-1
add-cla-workflow
js/pr-3-refactor
one-click
v0.10.2
v0.10.1
v0.10.0
v0.9.2
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/pyisolate#20
No description provided.