[PR #255] [MERGED] Attempt to use the build-in Lora.networks Lora/LyCORIS models lists #283

Closed
opened 2026-10-30 21:21:59 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/pull/255
Author: @midcoastal
Created: 12/7/2023
Status: ✅ Merged
Merged: 12/10/2023
Merged by: @DominikDoom

Base: main ← Head: LoraNetworksLists


📝 Commits (5)

  • 4b9d576 Attempt to use the build-in Lora.networks Lora/LyCORIS models lists
  • 5da0744 Use pathlib instead of string manipulation and compare.
  • cd99d58 Cleanup and remove the assert.
  • 54f151c Remove type-hints and import os
  • ae6ae67 Remove List import

📊 Changes

2 files changed (+67 additions, -6 deletions)

View changed files

📝 scripts/shared_paths.py (+4 -1)
📝 scripts/tag_autocomplete_helper.py (+63 -5)

📄 Description

This is a small performance patch for SD.Next. This attempts to load and use the built-in Lora.networks Lora/LyCORIS Models lists, so as not to duplicate the work that has already been done. This is not much of an issue on small collections, but I have a relatively large collection, and this cut the extension's load time from +200 seconds to ~20 seconds.

Work in shared_paths is a comparability patch to continue working with SD.Next if you have a separate LyCORIS directory still.

I have not tested with the "OG" A1111 WebUI, only SD.Next. I have been using this patch daily for a week or so now (the non backcompat is new, but the rest I have been using for a bit now), and it does seem to work well.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/pull/255 **Author:** [@midcoastal](https://github.com/midcoastal) **Created:** 12/7/2023 **Status:** ✅ Merged **Merged:** 12/10/2023 **Merged by:** [@DominikDoom](https://github.com/DominikDoom) **Base:** `main` ← **Head:** `LoraNetworksLists` --- ### 📝 Commits (5) - [`4b9d576`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/4b9d5767bbbee9ecad28f6471033d26cfbb69088) Attempt to use the build-in Lora.networks Lora/LyCORIS models lists - [`5da0744`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/5da0744504a54e3284b27aa17a9ce052a5f27b87) Use pathlib instead of string manipulation and compare. - [`cd99d58`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/cd99d58d23b5110b92d09ec08857e2a65dff1270) Cleanup and remove the assert. - [`54f151c`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/54f151c89f857364dcb91e098c546bc8d8a5f0f9) Remove type-hints and import os - [`ae6ae67`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/ae6ae67e122b04c74cd8da90583756a3a00db538) Remove List import ### 📊 Changes **2 files changed** (+67 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `scripts/shared_paths.py` (+4 -1) 📝 `scripts/tag_autocomplete_helper.py` (+63 -5) </details> ### 📄 Description This is a small performance patch for `SD.Next`. This attempts to load and use the built-in `Lora.networks` Lora/LyCORIS Models lists, so as not to duplicate the work that has already been done. This is not much of an issue on small collections, but I have a relatively large collection, and this cut the extension's load time from +200 seconds to ~20 seconds. Work in `shared_paths` is a comparability patch to continue working with SD.Next if you have a separate `LyCORIS` directory still. I have not tested with the "OG" A1111 WebUI, only SD.Next. I have been using this patch daily for a week or so now (the non `backcompat` is new, but the rest I have been using for a bit now), and it does seem to work well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-30 21:21:59 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
DominikDoom/a1111-sd-webui-tagcomplete#283
No description provided.