mirror of
https://github.com/DominikDoom/a1111-sd-webui-tagcomplete.git
synced 2026-11-05 00:17:25 +00:00
[PR #255] [MERGED] Attempt to use the build-in Lora.networks Lora/LyCORIS models lists #283
Labels
No labels
bug
duplicate
enhancement
help wanted
invalid
low priority
low priority
pull-request
question
waiting for feedback
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
DominikDoom/a1111-sd-webui-tagcomplete#283
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/pull/255
Author: @midcoastal
Created: 12/7/2023
Status: ✅ Merged
Merged: 12/10/2023
Merged by: @DominikDoom
Base:
main← Head:LoraNetworksLists📝 Commits (5)
4b9d576Attempt to use the build-in Lora.networks Lora/LyCORIS models lists5da0744Use pathlib instead of string manipulation and compare.cd99d58Cleanup and remove the assert.54f151cRemove type-hints and import osae6ae67Remove List import📊 Changes
2 files changed (+67 additions, -6 deletions)
View changed files
📝
scripts/shared_paths.py(+4 -1)📝
scripts/tag_autocomplete_helper.py(+63 -5)📄 Description
This is a small performance patch for
SD.Next. This attempts to load and use the built-inLora.networksLora/LyCORIS Models lists, so as not to duplicate the work that has already been done. This is not much of an issue on small collections, but I have a relatively large collection, and this cut the extension's load time from +200 seconds to ~20 seconds.Work in
shared_pathsis a comparability patch to continue working with SD.Next if you have a separateLyCORISdirectory still.I have not tested with the "OG" A1111 WebUI, only SD.Next. I have been using this patch daily for a week or so now (the non
backcompatis new, but the rest I have been using for a bit now), and it does seem to work well.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.