[PR #93] [MERGED] Umi suggestion filtering #255

New issue

Closed

opened 2026-10-30 21:21:42 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-30 21:21:42 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/pull/93
Author: @ctwrs
Created: 12/24/2022
Status: ✅ Merged
Merged: 12/26/2022
Merged by: @DominikDoom

Base: main ← Head: umi-suggestions

📝 Commits (3)

d2b5142 Umi filtering - initial version
0c3397a Fix umi tag autocomplete filtering logic
1620160 Merge branch 'DominikDoom:main' into umi-suggestions

📊 Changes

2 files changed (+117 additions, -13 deletions)

View changed files

📝 javascript/tagAutocomplete.js (+114 -8)
📝 scripts/tag_autocomplete_helper.py (+3 -5)

📄 Description

This is implementing an initial version of tag filtering. The goal is to get suggestions that take previous tags into account. This will make Umi prompting viable for widespread use. Right now debugging prompts it a bit tedious because we have to run the prompt to get debug info about what keywords get matched.

I still have to find a good solution for optional tags, so that it will match all other tags no matter where they are defined and only limit the selection to what's filtered through neg and pos parts.

https://user-images.githubusercontent.com/116893749/209415626-0444e51d-27b4-4fac-9928-c82dbb9d4f02.mov

Code quality and naming feedback appreciated. Wrote it late at night and I'm surprised it even works.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/pull/93 **Author:** [@ctwrs](https://github.com/ctwrs) **Created:** 12/24/2022 **Status:** ✅ Merged **Merged:** 12/26/2022 **Merged by:** [@DominikDoom](https://github.com/DominikDoom) **Base:** `main` ← **Head:** `umi-suggestions` --- ### 📝 Commits (3) - [`d2b5142`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/d2b5142d7d8834e35a41a297c0b5834c153302f9) Umi filtering - initial version - [`0c3397a`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/0c3397aee64c3b61ca2ff05b8f173e8ca6254ed7) Fix umi tag autocomplete filtering logic - [`1620160`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/16201605d0b3b5222fca02eaaf168a516a51dcba) Merge branch 'DominikDoom:main' into umi-suggestions ### 📊 Changes **2 files changed** (+117 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `javascript/tagAutocomplete.js` (+114 -8) 📝 `scripts/tag_autocomplete_helper.py` (+3 -5) </details> ### 📄 Description This is implementing an initial version of tag filtering. The goal is to get suggestions that take previous tags into account. This will make Umi prompting viable for widespread use. Right now debugging prompts it a bit tedious because we have to run the prompt to get debug info about what keywords get matched. I still have to find a good solution for optional tags, so that it will match all other tags no matter where they are defined and only limit the selection to what's filtered through neg and pos parts. https://user-images.githubusercontent.com/116893749/209415626-0444e51d-27b4-4fac-9928-c82dbb9d4f02.mov Code quality and naming feedback appreciated. Wrote it late at night and I'm surprised it even works. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-30 21:21:42 +00:00