[PR #258] [MERGED] Attempt to use the build-in Lora.networks Lora/LyCORIS models lists #288

New issue

Closed

opened 2026-10-30 21:22:01 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-30 21:22:01 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/pull/258
Author: @DominikDoom
Created: 12/11/2023
Status: ✅ Merged
Merged: 12/11/2023
Merged by: @DominikDoom

Base: main ← Head: use-existing-lora-list

📝 Commits (9)

4b9d576 Attempt to use the build-in Lora.networks Lora/LyCORIS models lists
5da0744 Use pathlib instead of string manipulation and compare.
cd99d58 Cleanup and remove the assert.
54f151c Remove type-hints and import os
ae6ae67 Remove List import
1d832b5 Fix absolute/relative check
60bc81f Formatting
3b55642 Use absolute paths in fallback too
9677998 Use absolute paths everywhere

📊 Changes

2 files changed (+85 additions, -22 deletions)

View changed files

📝 scripts/shared_paths.py (+15 -12)
📝 scripts/tag_autocomplete_helper.py (+70 -10)

📄 Description

Fixed and formatted result of PRs #255 and #257.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/pull/258 **Author:** [@DominikDoom](https://github.com/DominikDoom) **Created:** 12/11/2023 **Status:** ✅ Merged **Merged:** 12/11/2023 **Merged by:** [@DominikDoom](https://github.com/DominikDoom) **Base:** `main` ← **Head:** `use-existing-lora-list` --- ### 📝 Commits (9) - [`4b9d576`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/4b9d5767bbbee9ecad28f6471033d26cfbb69088) Attempt to use the build-in Lora.networks Lora/LyCORIS models lists - [`5da0744`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/5da0744504a54e3284b27aa17a9ce052a5f27b87) Use pathlib instead of string manipulation and compare. - [`cd99d58`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/cd99d58d23b5110b92d09ec08857e2a65dff1270) Cleanup and remove the assert. - [`54f151c`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/54f151c89f857364dcb91e098c546bc8d8a5f0f9) Remove type-hints and import os - [`ae6ae67`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/ae6ae67e122b04c74cd8da90583756a3a00db538) Remove List import - [`1d832b5`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/1d832b5bc39e96b4bbc7104249a51ec5a39ca869) Fix absolute/relative check - [`60bc81f`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/60bc81f095b8afe59b69f51e7a6f6c802442bd87) Formatting - [`3b55642`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/3b556427ec5736f02a3ef0514232c51d79be7ebb) Use absolute paths in fallback too - [`9677998`](https://github.com/DominikDoom/a1111-sd-webui-tagcomplete/commit/9677998f1adfe05ce37a7b22974f72b4d33118da) Use absolute paths everywhere ### 📊 Changes **2 files changed** (+85 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `scripts/shared_paths.py` (+15 -12) 📝 `scripts/tag_autocomplete_helper.py` (+70 -10) </details> ### 📄 Description Fixed and formatted result of PRs #255 and #257. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-30 21:22:01 +00:00