[PR #91] [MERGED] Fix incomplete videos downloading issue #104

Closed
opened 2026-10-13 19:47:19 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Glitchy-Sheep/boosty-downloader/pull/91
Author: @Glitchy-Sheep
Created: 2/8/2026
Status: ✅ Merged
Merged: 2/8/2026
Merged by: @Glitchy-Sheep

Base: main ← Head: fix/unfinished-video-downloading


📝 Commits (2)

  • a35213b Fix incomplete videos downloading issue
  • 15af1c2 chore: bump version to 2.1.1

📊 Changes

8 files changed (+218 additions, -17 deletions)

View changed files

📝 CHANGELOG.md (+4 -0)
📝 boosty_downloader/src/application/mappers/__init__.py (+2 -1)
📝 boosty_downloader/src/application/mappers/post_mapper.py (+40 -7)
📝 boosty_downloader/src/application/use_cases/download_single_post.py (+21 -6)
📝 boosty_downloader/src/infrastructure/boosty_api/models/post/post_data_types/post_data_ok_video.py (+1 -1)
📝 pyproject.toml (+2 -2)
➕ test/unit/mappers/__init__.py (+0 -0)
➕ test/unit/mappers/post_mapper_test.py (+148 -0)

📄 Description

📌 Fix incomplete videos downloading issue

📝 Description

When some videos are still in processing by the boosty the uploadingStatus is None, which is crashing the app entirely.
The fix checks that field now and skip unfinished parts and not caches them.

🔄 Changelog

  • ✨ Added:
    • Tests for the unfinished videos processing
  • 🛠 Fixed: …
    • The problem with unfinished videos processing

Closes #90

✅ Checklist

  • Locally tested (make test and your own judgment)
  • Documentation updated (if necessary)
  • Code follows the project's style guidelines (make lint && make format)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Glitchy-Sheep/boosty-downloader/pull/91 **Author:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Created:** 2/8/2026 **Status:** ✅ Merged **Merged:** 2/8/2026 **Merged by:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Base:** `main` ← **Head:** `fix/unfinished-video-downloading` --- ### 📝 Commits (2) - [`a35213b`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/a35213b128f01ecf19a53c7dce0e776998251dcd) Fix incomplete videos downloading issue - [`15af1c2`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/15af1c28866d22bfed6b144bdc01d9fe64f2c6f9) chore: bump version to 2.1.1 ### 📊 Changes **8 files changed** (+218 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -0) 📝 `boosty_downloader/src/application/mappers/__init__.py` (+2 -1) 📝 `boosty_downloader/src/application/mappers/post_mapper.py` (+40 -7) 📝 `boosty_downloader/src/application/use_cases/download_single_post.py` (+21 -6) 📝 `boosty_downloader/src/infrastructure/boosty_api/models/post/post_data_types/post_data_ok_video.py` (+1 -1) 📝 `pyproject.toml` (+2 -2) ➕ `test/unit/mappers/__init__.py` (+0 -0) ➕ `test/unit/mappers/post_mapper_test.py` (+148 -0) </details> ### 📄 Description # 📌 Fix incomplete videos downloading issue ## 📝 Description When some videos are still in processing by the boosty the uploadingStatus is None, which is crashing the app entirely. The fix checks that field now and skip unfinished parts and not caches them. ## 🔄 Changelog <!-- Please provide a list of general changes made in this PR --> - **✨ Added:** - Tests for the unfinished videos processing - **🛠 Fixed:** … - The problem with unfinished videos processing ## 🎯 Related Issue <!-- Reference related issues, e.g., Closes #123 --> Closes #90 ## ✅ Checklist - [x] Locally tested (`make test` and your own judgment) - [x] Documentation updated (if necessary) - [x] Code follows the project's style guidelines (`make lint && make format`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-13 19:47:19 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Glitchy-Sheep/boosty-downloader#104
No description provided.