[PR #100] [MERGED] Add --cache-dir flag for custom cache database location #109

New issue

Closed

opened 2026-10-13 19:47:25 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 19:47:25 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Glitchy-Sheep/boosty-downloader/pull/100
Author: @Glitchy-Sheep
Created: 4/12/2026
Status: ✅ Merged
Merged: 4/12/2026
Merged by: @Glitchy-Sheep

Base: main ← Head: feat/cache-dir

📝 Commits (5)

3abc488 Add --cache-dir flag for custom cache database location
fe625a6 Update changelog.md
2947c9e Better help for new option
90a4241 Fix CI: full clone for changelog diff and remove duplicate push trigger
ae9f8a8 Stricter CHANGELOG CI check: validate additions to Unreleased section

📊 Changes

6 files changed (+81 additions, -13 deletions)

View changed files

📝 .github/workflows/ci.yaml (+51 -12)
📝 CHANGELOG.md (+2 -0)
📝 boosty_downloader/main.py (+11 -0)
📝 boosty_downloader/src/application/di/app_environment.py (+3 -1)
📝 boosty_downloader/src/cli/cli_options.py (+13 -0)
📝 boosty_downloader/src/infrastructure/yaml_configuration/config.py (+1 -0)

📄 Description

📝 Summary

Add --cache-dir CLI flag and cache_directory config.yaml option to store the SQLite cache database separately from downloads.

SQLite requires OS-level file locking which doesn't work reliably on network filesystems (CIFS/SMB). Users downloading to NAS get database is locked errors even with a single process. This flag allows placing the cache on a local disk while keeping downloads on network storage.

When not specified, cache stays next to downloads as before - no behavior change for existing users.

Also fixes CI: full git clone for changelog diff check and removes duplicate push trigger.

Closes #95

✅ Checklist

Locally tested (make test)
CI checks pass (make ci-check)
Added a line to ## Unreleased section in CHANGELOG.md describing the change (or added ci/skip-changelog label if not user-facing)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Glitchy-Sheep/boosty-downloader/pull/100 **Author:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Created:** 4/12/2026 **Status:** ✅ Merged **Merged:** 4/12/2026 **Merged by:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Base:** `main` ← **Head:** `feat/cache-dir` --- ### 📝 Commits (5) - [`3abc488`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/3abc488e5959cce86bd205daebc5edcfaee709d2) Add --cache-dir flag for custom cache database location - [`fe625a6`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/fe625a6572984f35773be9fbe1597025ee9ad6ed) Update changelog.md - [`2947c9e`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/2947c9edc32c31b9fbc1aeac895f11ef9bfe5472) Better help for new option - [`90a4241`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/90a4241aff445604b28929a991863e6c6a06eff7) Fix CI: full clone for changelog diff and remove duplicate push trigger - [`ae9f8a8`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/ae9f8a8d1e64f3327d1afa8339b09120a9b8570a) Stricter CHANGELOG CI check: validate additions to Unreleased section ### 📊 Changes **6 files changed** (+81 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yaml` (+51 -12) 📝 `CHANGELOG.md` (+2 -0) 📝 `boosty_downloader/main.py` (+11 -0) 📝 `boosty_downloader/src/application/di/app_environment.py` (+3 -1) 📝 `boosty_downloader/src/cli/cli_options.py` (+13 -0) 📝 `boosty_downloader/src/infrastructure/yaml_configuration/config.py` (+1 -0) </details> ### 📄 Description ## 📝 Summary Add `--cache-dir` CLI flag and `cache_directory` config.yaml option to store the SQLite cache database separately from downloads. SQLite requires OS-level file locking which doesn't work reliably on network filesystems (CIFS/SMB). Users downloading to NAS get `database is locked` errors even with a single process. This flag allows placing the cache on a local disk while keeping downloads on network storage. When not specified, cache stays next to downloads as before - no behavior change for existing users. Also fixes CI: full git clone for changelog diff check and removes duplicate push trigger. ## 🎯 Related Issue Closes #95 ## ✅ Checklist - [x] Locally tested (`make test`) - [x] CI checks pass (`make ci-check`) - [x] Added a line to `## Unreleased` section in CHANGELOG.md describing the change (or added `ci/skip-changelog` label if not user-facing) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 19:47:25 +00:00