[PR #119] [MERGED] [build] Add make setup for first-time dev environment #122

Closed
opened 2026-10-13 19:47:37 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Glitchy-Sheep/boosty-downloader/pull/119
Author: @Glitchy-Sheep
Created: 8/8/2026
Status: ✅ Merged
Merged: 8/8/2026
Merged by: @Glitchy-Sheep

Base: main ← Head: chore/make-setup


📝 Commits (1)

  • 661bc8f chore: 🔨 Add make setup for first-time dev environment

📊 Changes

1 file changed (+17 additions, -1 deletions)

View changed files

📝 Makefile (+17 -1)

📄 Description

Summary

One command gets a fresh clone ready: the venv lands inside the project, dependencies install, and VS Code gets interpreter settings. No more "Import could not be resolved" on a new machine.

Problem

  • A fresh clone got its venv in the global poetry cache, so editors pointed at a wrong or empty interpreter
  • Pylance painted every third-party import red while the code ran fine from the terminal
  • .vscode/settings.json is gitignored, so the fix could not be shared by committing it

Fix

  • make setup runs poetry config virtualenvs.in-project true --local, installs dependencies and generates .vscode/settings.json with python.defaultInterpreterPath pointing at ./.venv
  • An existing settings file is never overwritten - the target only prints what to check
  • The target is listed first in make help under Quick start

Tests

  • Ran both paths by hand: with an existing settings file (untouched, hint printed) and without one (file generated, ${workspaceFolder} survives the Makefile escaping)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Glitchy-Sheep/boosty-downloader/pull/119 **Author:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Created:** 8/8/2026 **Status:** ✅ Merged **Merged:** 8/8/2026 **Merged by:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Base:** `main` ← **Head:** `chore/make-setup` --- ### 📝 Commits (1) - [`661bc8f`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/661bc8fec858ef2a2c2088b6f371b3adb18f88eb) chore: :hammer: Add `make setup` for first-time dev environment ### 📊 Changes **1 file changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+17 -1) </details> ### 📄 Description ## Summary One command gets a fresh clone ready: the venv lands inside the project, dependencies install, and VS Code gets interpreter settings. No more "Import could not be resolved" on a new machine. ## Problem - A fresh clone got its venv in the global poetry cache, so editors pointed at a wrong or empty interpreter - Pylance painted every third-party import red while the code ran fine from the terminal - `.vscode/settings.json` is gitignored, so the fix could not be shared by committing it ## Fix - `make setup` runs `poetry config virtualenvs.in-project true --local`, installs dependencies and generates `.vscode/settings.json` with `python.defaultInterpreterPath` pointing at `./.venv` - An existing settings file is never overwritten - the target only prints what to check - The target is listed first in `make help` under Quick start ## Tests - Ran both paths by hand: with an existing settings file (untouched, hint printed) and without one (file generated, `${workspaceFolder}` survives the Makefile escaping) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-13 19:47:37 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Glitchy-Sheep/boosty-downloader#122
No description provided.