[PR #201] [MERGED] [tests] Read the root help through the ANSI-stripping helper #200

New issue

Closed

opened 2026-10-13 19:48:44 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 19:48:44 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Glitchy-Sheep/boosty-downloader/pull/201
Author: @Glitchy-Sheep
Created: 9/22/2026
Status: ✅ Merged
Merged: 9/22/2026
Merged by: @Glitchy-Sheep

Base: main ← Head: fix/help-test-ansi

📝 Commits (1)

8e5f178 [tests] Read the root help through the ANSI-stripping helper

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 test/unit/cli/cli_smoke_test.py (+4 -3)

📄 Description

📝 Summary

Main has been red since #198 on one test: test_root_help_names_the_env_var checked --config in the raw help output, and in CI rich colors the option name, so escape codes split the string. The same helper the file already uses for panel text (_plain_text) fixes it.

Reproduced locally with COLUMNS=80 FORCE_COLOR=1 uv run pytest test/unit/cli; the whole suite passes under that environment, 323 tests, and task ci is green.

Nothing in the product changes.

✅ Checklist

Tested live on a real blog (feature or fix)
Updated CLI --help and README if needed
Updated docs/ if the download flow or dev process changed
Added a line to ## Unreleased in CHANGELOG.md (or the ci/skip-changelog label if not user-facing)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Glitchy-Sheep/boosty-downloader/pull/201 **Author:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Created:** 9/22/2026 **Status:** ✅ Merged **Merged:** 9/22/2026 **Merged by:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Base:** `main` ← **Head:** `fix/help-test-ansi` --- ### 📝 Commits (1) - [`8e5f178`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/8e5f178aafc06c14f720be8cc1df62a8e841fc16) [tests] Read the root help through the ANSI-stripping helper ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `test/unit/cli/cli_smoke_test.py` (+4 -3) </details> ### 📄 Description ## 📝 Summary Main has been red since #198 on one test: `test_root_help_names_the_env_var` checked `--config` in the raw help output, and in CI rich colors the option name, so escape codes split the string. The same helper the file already uses for panel text (`_plain_text`) fixes it. Reproduced locally with `COLUMNS=80 FORCE_COLOR=1 uv run pytest test/unit/cli`; the whole suite passes under that environment, 323 tests, and `task ci` is green. Nothing in the product changes. ## ✅ Checklist - [x] Tested live on a real blog (feature or fix) - [x] Updated CLI `--help` and README if needed - [x] Updated `docs/` if the download flow or dev process changed - [x] Added a line to `## Unreleased` in CHANGELOG.md (or the `ci/skip-changelog` label if not user-facing) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 19:48:44 +00:00