[PR #211] [MERGED] fix(scripts): escape GitHub text twice for the Telegram action #210

New issue

Closed

opened 2026-10-13 19:48:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 19:48:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Glitchy-Sheep/boosty-downloader/pull/211
Author: @Glitchy-Sheep
Created: 9/23/2026
Status: ✅ Merged
Merged: 9/23/2026
Merged by: @Glitchy-Sheep

Base: main ← Head: fix/weekly-report-escaping

📝 Commits (1)

ead3a28 fix(scripts): escape GitHub text twice for the Telegram action

📊 Changes

1 file changed (+10 additions, -4 deletions)

View changed files

📝 scripts/weekly_report.py (+10 -4)

📄 Description

📝 Summary

The weekly report failed to send: can't parse entities: Unsupported start tag "blog". appleboy/telegram-action decodes HTML entities once before sending, so an escaped <blog> turned back into a raw <blog> tag. Text from GitHub is now escaped twice.

🔧 What changes

_escape escapes twice, with a comment on why. PR and issue titles, API change paths and the accept hint go through it.
A PR or issue title with < or & would have broken the report the same way.

🧪 Tests

Reproduced with the action image locally: a single-escaped  fails with the same error, a double-escaped one arrives as .
The full report with the 🔭 API changes block sent through the action image: delivered.
ruff and pyright pass.

✅ Checklist

Tested live on a real blog (feature or fix)
Updated CLI --help and README if needed
Updated docs/ if the download flow or dev process changed
Added a line to ## Unreleased in CHANGELOG.md (or the ci/skip-changelog label if not user-facing)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Glitchy-Sheep/boosty-downloader/pull/211 **Author:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Created:** 9/23/2026 **Status:** ✅ Merged **Merged:** 9/23/2026 **Merged by:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Base:** `main` ← **Head:** `fix/weekly-report-escaping` --- ### 📝 Commits (1) - [`ead3a28`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/ead3a280024a9c9be2fbc2a98138a92052da6c5e) fix(scripts): escape GitHub text twice for the Telegram action ### 📊 Changes **1 file changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `scripts/weekly_report.py` (+10 -4) </details> ### 📄 Description ## 📝 Summary The weekly report failed to send: `can't parse entities: Unsupported start tag "blog"`. `appleboy/telegram-action` decodes HTML entities once before sending, so an escaped `<blog>` turned back into a raw `<blog>` tag. Text from GitHub is now escaped twice. ## 🔧 What changes - `_escape` escapes twice, with a comment on why. PR and issue titles, API change paths and the accept hint go through it. - A PR or issue title with `<` or `&` would have broken the report the same way. ## 🧪 Tests - Reproduced with the action image locally: a single-escaped `` fails with the same error, a double-escaped one arrives as ``. - The full report with the 🔭 API changes block sent through the action image: delivered. - ruff and pyright pass. ## ✅ Checklist  - [x] Tested live on a real blog (feature or fix) - [x] Updated CLI `--help` and README if needed - [x] Updated `docs/` if the download flow or dev process changed - [x] Added a line to `## Unreleased` in CHANGELOG.md (or the `ci/skip-changelog` label if not user-facing) --- 🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

bsakaguchi

2026-10-13 19:48:54 +00:00