[PR #50] [MERGED] Improve tests and error handling #76

New issue

Closed

opened 2026-10-13 19:46:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 19:46:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Glitchy-Sheep/boosty-downloader/pull/50
Author: @Glitchy-Sheep
Created: 7/31/2025
Status: ✅ Merged
Merged: 7/31/2025
Merged by: @Glitchy-Sheep

Base: dev ← Head: fix/improve-integration-tests

📝 Commits (3)

ade5ea2 fix: 📝 Fix Makefile targets
f4233d4 test: 🐛 Fix fixture usage, add invalid_auth test case, better fixtures structure/naming
0cb7208 feat: ✨ Better error handling messages, add validation error handler and generic unexpected error handler

📊 Changes

6 files changed (+158 additions, -46 deletions)

View changed files

📝 Makefile (+2 -2)
📝 boosty_downloader/main.py (+14 -2)
📝 boosty_downloader/src/boosty_api/core/client.py (+36 -5)
📝 test/integration/analysis/get_author_posts_test.py (+4 -4)
📝 test/integration/boosty_api/boosty_api_test.py (+25 -20)
📝 test/integration/fixtures.py (+77 -13)

📄 Description

📌 Improve tests and error handling

📝 Description

I misused authorized http_session in unauthorized retry client, so I fixed it and did better naming for fixtures in general.

Also add missing error handling and improve their messages.

🔄 Changelog

✨ Added::
- Validation error handler
- Generic boosty api error handler
🛠 Fixed:
- Misuse of http_session fixture
- Makefile targets names

✅ Checklist

Locally tested (make test and your own judgment)
Documentation updated (if necessary)
Code follows the project's style guidelines (make lint && make format)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Glitchy-Sheep/boosty-downloader/pull/50 **Author:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Created:** 7/31/2025 **Status:** ✅ Merged **Merged:** 7/31/2025 **Merged by:** [@Glitchy-Sheep](https://github.com/Glitchy-Sheep) **Base:** `dev` ← **Head:** `fix/improve-integration-tests` --- ### 📝 Commits (3) - [`ade5ea2`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/ade5ea2da0b2c848a5a1bfe98e0aafe7e8fe6415) fix: :memo: Fix Makefile targets - [`f4233d4`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/f4233d41cc0e08a5ef869d42f9aef1f9b535b5cb) test: :bug: Fix fixture usage, add invalid_auth test case, better fixtures structure/naming - [`0cb7208`](https://github.com/Glitchy-Sheep/boosty-downloader/commit/0cb7208e410a65f5f7a28778fe7997f2a061db53) feat: :sparkles: Better error handling messages, add validation error handler and generic unexpected error handler ### 📊 Changes **6 files changed** (+158 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+2 -2) 📝 `boosty_downloader/main.py` (+14 -2) 📝 `boosty_downloader/src/boosty_api/core/client.py` (+36 -5) 📝 `test/integration/analysis/get_author_posts_test.py` (+4 -4) 📝 `test/integration/boosty_api/boosty_api_test.py` (+25 -20) 📝 `test/integration/fixtures.py` (+77 -13) </details> ### 📄 Description # 📌 Improve tests and error handling ## 📝 Description I misused authorized http_session in unauthorized retry client, so I fixed it and did better naming for fixtures in general. Also add missing error handling and improve their messages. ## 🔄 Changelog  - **✨ Added:**: - Validation error handler - Generic boosty api error handler - **🛠 Fixed:** - Misuse of http_session fixture - Makefile targets names ## ✅ Checklist - [x] Locally tested (`make test` and your own judgment) - [x] Documentation updated (if necessary) - [x] Code follows the project's style guidelines (`make lint && make format`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 19:46:54 +00:00