NVIDIA/nvbench
1
0
Fork 0
mirror of https://github.com/NVIDIA/nvbench.git synced 2026-04-19 22:38:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #133 from robertmaynard/bug/handle_conda_env_static_fmt

Browse Source 
Handle use case where we are in a conda env but with a static fmt lib
This commit is contained in:
Allison Vacanti
2023-05-31 13:56:56 -04:00
committed by GitHub
parent 702ab05751 b8b5d2904b
commit 083fdc2fc1
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
cmake/NVBenchDependencies.cmake
View File

@@ -10,6 +10,9 @@ rapids_cpm_find(fmt 9.1.0
"BUILD_SHARED_LIBS OFF"
"CMAKE_POSITION_INDEPENDENT_CODE ON"
)
if(NOT fmt_ADDED)
set(fmt_is_external TRUE)
endif()
if(TARGET fmt::fmt AND NOT TARGET fmt)
add_library(fmt ALIAS fmt::fmt)

13
nvbench/CMakeLists.txt
View File

@@ -89,8 +89,17 @@ if(TARGET conda_env)
#
# Since we could be using a shared library version of fmt we need
# it on the final link line of consumers
target_link_libraries(nvbench PRIVATE $<BUILD_INTERFACE:conda_env>
PUBLIC fmt::fmt)
target_link_libraries(nvbench PRIVATE $<BUILD_INTERFACE:conda_env>)
endif()
# When we are inside a conda env the linker will be set to
# `ld.bfd` which will try to resolve all undefined symbols at link time.
#
# Since we could be using a shared library version of fmt we need
# it on the final link line of consumers
if(TARGET conda_env AND fmt_is_external)
target_link_libraries(nvbench PUBLIC fmt::fmt)
else()
target_link_libraries(nvbench PRIVATE fmt::fmt)
endif()