Rename get_params to get_params_description

This commit is contained in:
Georgy Evtushenko
2024-01-08 13:06:48 -08:00
parent 88cc582cea
commit de724a21f1
8 changed files with 9 additions and 9 deletions

View File

@@ -50,8 +50,8 @@ public:
return m_num_samples >= m_max_samples;
}
// Describe criterion parameters in the `get_params()` method:
virtual const params_description &get_params() const override
// Describe criterion parameters in the `get_params_description()` method:
virtual const params_description &get_params_description() const override
{
static const params_description desc{
{"max-samples", nvbench::named_values::type::int64}

View File

@@ -67,7 +67,7 @@ nvbench::stopping_criterion::params_description criterion_registry::get_params_d
criterion_registry &registry = instance();
for (auto &[criterion_name, criterion] : registry.m_map)
{
for (auto param : criterion->get_params())
for (auto param : criterion->get_params_description())
{
if (std::find_if(desc.begin(), desc.end(), [&](auto d) {
return d.first == param.first && d.second != param.second;

View File

@@ -48,7 +48,7 @@ public:
virtual void initialize(const criterion_params &params) override;
virtual void add_measurement(nvbench::float64_t measurement) override;
virtual bool is_finished() override;
virtual const params_description &get_params() const override;
virtual const params_description &get_params_description() const override;
};
} // namespace nvbench::detail

View File

@@ -141,7 +141,7 @@ bool entropy_criterion::is_finished()
return true;
}
const entropy_criterion::params_description &entropy_criterion::get_params() const
const entropy_criterion::params_description &entropy_criterion::get_params_description() const
{
static const params_description desc{
{"max-angle", nvbench::named_values::type::float64},

View File

@@ -43,7 +43,7 @@ public:
virtual void initialize(const criterion_params &params) override;
virtual void add_measurement(nvbench::float64_t measurement) override;
virtual bool is_finished() override;
virtual const params_description &get_params() const override;
virtual const params_description &get_params_description() const override;
};
} // namespace nvbench::detail

View File

@@ -99,7 +99,7 @@ bool stdrel_criterion::is_finished()
return false;
}
const stdrel_criterion::params_description &stdrel_criterion::get_params() const
const stdrel_criterion::params_description &stdrel_criterion::get_params_description() const
{
static const params_description desc{
{"max-noise", nvbench::named_values::type::float64},

View File

@@ -80,7 +80,7 @@ public:
/**
* Return the parameter names and types for this criterion
*/
virtual const params_description &get_params() const = 0;
virtual const params_description &get_params_description() const = 0;
};
} // namespace nvbench

View File

@@ -33,7 +33,7 @@ public:
virtual void initialize(const nvbench::criterion_params &) override {}
virtual void add_measurement(nvbench::float64_t /* measurement */) override {}
virtual bool is_finished() override { return true; }
virtual const params_description &get_params() const override
virtual const params_description &get_params_description() const override
{
static const params_description desc{};
return desc;