ROCm/composable_kernel
1
0
Fork 0
mirror of https://github.com/ROCm/composable_kernel.git synced 2026-05-14 10:09:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

[CK-TILE] Guard against compiler lexer diagnostic (#3444)

Browse Source 
* [CK-TILE] Guard against compiler lexer diagnostic

A recent change to Clang added a lexer-level diagnostic about that C2y
language feature. Since that is lexer level, the `__extension__`
compiler built-in does not work as it is only respected *after* the
lexer when parsing.

This change adds guarding pragmas to disable the diagnostic in the
lexer and not lead to warnings being treated as errors.

* Fixing still existing build issue

Once the one warning was removed, another one poppoed up. Both are
related to the same c2y feature. Thus, ignoring both.

* clang-format handling

---------

Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>

[ROCm/composable_kernel commit: 9bd67c2cf2]
This commit is contained in:
Jan Patrick Lehr
2025-12-20 02:32:20 +01:00
committed by GitHub
parent 38ff45abf7
commit 500d143fa8
2 changed files with 32 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
include/ck_tile/core/utility/static_counter.hpp
View File

@@ -101,15 +101,30 @@ template <int I>
struct static_counter_uniq_;
}
#define MAKE_SC() \
__extension__ ck_tile::static_counter<ck_tile::impl::static_counter_uniq_<__COUNTER__>> {}
// clang-format off
#define MAKE_SC() \
_Pragma("clang diagnostic push") \
_Pragma("clang diagnostic ignored \"-Wpre-c2y-compat\"") \
_Pragma("clang diagnostic ignored \"-Wc2y-extensions\"") \
ck_tile::static_counter<ck_tile::impl::static_counter_uniq_<__COUNTER__>>{} \
_Pragma("clang diagnostic pop")
#define MAKE_SC_WITH(start_, step_) \
__extension__ ck_tile:: \
static_counter<ck_tile::impl::static_counter_uniq_<__COUNTER__>, start_, step_> \
{ \
}
#define NEXT_SC(c_) __extension__ c_.next<__COUNTER__>()
#define NEXT_SCI(c_, static_i_) __extension__ c_.next<__COUNTER__ + static_i_>()
_Pragma("clang diagnostic push") \
_Pragma("clang diagnostic ignored \"-Wpre-c2y-compat\"") \
_Pragma("clang diagnostic ignored \"-Wc2y-extensions\"") ck_tile:: \
static_counter<ck_tile::impl::static_counter_uniq_<__COUNTER__>, start_, step_>{} \
_Pragma("clang diagnostic pop")
#define NEXT_SC(c_) \
_Pragma("clang diagnostic push") \
_Pragma("clang diagnostic ignored \"-Wpre-c2y-compat\"") \
_Pragma("clang diagnostic ignored \"-Wc2y-extensions\"") c_.next<__COUNTER__>() \
_Pragma("clang diagnostic pop")
#define NEXT_SCI(c_, static_i_) \
_Pragma("clang diagnostic push") \
_Pragma("clang diagnostic ignored \"-Wpre-c2y-compat\"") \
_Pragma("clang diagnostic ignored \"-Wc2y-extensions\"") \
c_.next<__COUNTER__ + static_i_>() _Pragma("clang diagnostic pop")
// clang-format on
// Usage:
// constexpr auto c = MAKE_SC()

12
profiler/src/profiler_operation_registry.hpp
View File

@@ -74,6 +74,12 @@ class ProfilerOperationRegistry final
#define PP_CONCAT(x, y) PP_CONCAT_IMPL(x, y)
#define PP_CONCAT_IMPL(x, y) x##y
#define REGISTER_PROFILER_OPERATION(name, description, operation) \
__extension__ static const bool PP_CONCAT(operation_registration_result_, __COUNTER__) = \
::ProfilerOperationRegistry::GetInstance().Add(name, description, operation)
// clang-format off
#define REGISTER_PROFILER_OPERATION(name, description, operation) \
_Pragma("clang diagnostic push") \
_Pragma("clang diagnostic ignored \"-Wpre-c2y-compat\"") \
_Pragma("clang diagnostic ignored \"-Wc2y-extensions\"") static const bool \
PP_CONCAT(operation_registration_result_, __COUNTER__) = \
::ProfilerOperationRegistry::GetInstance().Add(name, description, operation) \
_Pragma("clang diagnostic pop")
// clang-format on